From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264955AbUEQKCX (ORCPT ); Mon, 17 May 2004 06:02:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264957AbUEQKCW (ORCPT ); Mon, 17 May 2004 06:02:22 -0400 Received: from cantor.suse.de ([195.135.220.2]:24762 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S264955AbUEQKCG (ORCPT ); Mon, 17 May 2004 06:02:06 -0400 Date: Mon, 17 May 2004 12:01:59 +0200 From: Andi Kleen To: Andi Kleen , davej@redhat.com, akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: i810 AGP fails to initialise (was Re: 2.6.6-mm2) Message-ID: <20040517100159.GC4903@wotan.suse.de> References: <20040513032736.40651f8e.akpm@osdl.org> <6usme4v66s.fsf@zork.zork.net> <20040513135308.GA2622@redhat.com> <20040513155841.6022e7b0.ak@suse.de> <6ulljwtoge.fsf@zork.zork.net> <20040513174110.5b397d84.ak@suse.de> <6u8yfvsbd4.fsf@zork.zork.net> <6uk6zeow52.fsf@zork.zork.net> <6u65avmo97.fsf@zork.zork.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6u65avmo97.fsf@zork.zork.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2004 at 09:49:56AM +0100, Sean Neakums wrote: > Sean Neakums writes: > > > Sean Neakums writes: > > > >> Andi Kleen writes: > >> > >>> Sean, can you double check that when you compile the AGP driver as module > >>> that the 7124 PCI ID appears in modinfo intel-agp ? > >>> And does the module also refuse to load ? > >> > >> I rebuilt with agpgart, intel-agp and i810 as modules, modprobed them, > >> and it works. > > > > I just realised that I probably forgot to reapply the patch before > > doing this test. Will check Monday. Sorry about this. > > Below is modinfo output. The module loads but doesn't initialise the > AGP. Someone else reported that it worked modular at least. When you apply the following patch what output do you get in the kernel log when you load the module? -Andi --- linux-2.6.6-work/drivers/char/agp/intel-agp.c.~2~ 2004-05-10 20:59:24.000000000 +0200 +++ linux-2.6.6-work/drivers/char/agp/intel-agp.c 2004-05-17 11:56:01.000000000 +0200 @@ -1263,9 +1263,13 @@ u8 cap_ptr = 0; struct resource *r; + printk("agp_intel_probe device %x\n", pdev->device); + cap_ptr = pci_find_capability(pdev, PCI_CAP_ID_AGP); - if (!cap_ptr) + if (!cap_ptr) { + printk("no cap\n"); return -ENODEV; + } bridge = agp_alloc_bridge(); if (!bridge) @@ -1432,6 +1436,7 @@ pci_set_drvdata(pdev, bridge); return agp_add_bridge(bridge); fail: + printk("failure\n"); agp_put_bridge(bridge); return -ENODEV; } @@ -1518,6 +1523,7 @@ return 0; agp_initialised=1; + printk("agp_intel_init\n"); return pci_module_init(&agp_intel_pci_driver); }