From: Andrew Morton <akpm@osdl.org>
To: Jan Kara <jack@ucw.cz>
Cc: torvalds@osdl.org, mark.williamson@imperial.ac.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Quota fix 3 - quota file corruption
Date: Mon, 17 May 2004 13:57:09 -0700 [thread overview]
Message-ID: <20040517135709.031a9311.akpm@osdl.org> (raw)
In-Reply-To: <20040517161028.GB23294@atrey.karlin.mff.cuni.cz>
Jan Kara <jack@ucw.cz> wrote:
>
> + memset(&empty, 0, sizeof(struct v2_disk_dqblk));
> + if (!memcmp(&empty, &ddquot, sizeof(struct v2_disk_dqblk)))
> + ddquot.dqb_itime = cpu_to_le64(1);
hm, OK.
Comparing structures for equality might not work right if the compiler
added internal padding. However in this case the structure is six u32's
followed by a couple of u64's so it will work out right. And it's an
on-disk thing so it won't be changing in a hurry.
prev parent reply other threads:[~2004-05-17 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-17 16:10 Jan Kara
2004-05-17 20:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040517135709.031a9311.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jack@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.williamson@imperial.ac.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®