From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263623AbUESLCn (ORCPT ); Wed, 19 May 2004 07:02:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263632AbUESLBw (ORCPT ); Wed, 19 May 2004 07:01:52 -0400 Received: from anor.ics.muni.cz ([147.251.4.35]:54405 "EHLO anor.ics.muni.cz") by vger.kernel.org with ESMTP id S263624AbUESLBY (ORCPT ); Wed, 19 May 2004 07:01:24 -0400 Date: Wed, 19 May 2004 13:01:05 +0200 From: Jan Kasprzak To: Jakub Jelinek Cc: Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: sendfile -EOVERFLOW on AMD64 Message-ID: <20040519110105.GC7836@fi.muni.cz> References: <1XuW9-3G0-23@gated-at.bofh.it> <20040519103855.GF18896@fi.muni.cz> <20040519105805.GK30909@devserv.devel.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040519105805.GK30909@devserv.devel.redhat.com> User-Agent: Mutt/1.4.2i X-Muni-Spam-TestIP: 147.251.48.3 X-Muni-Virus-Test: Clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jakub Jelinek wrote: : For XFS I'd expect this: : STATIC ssize_t : linvfs_sendfile( : struct file *filp, : loff_t *ppos, : size_t count, : read_actor_t actor, : void *target) : { : vnode_t *vp = LINVFS_GET_VP(filp->f_dentry->d_inode); : int error; : : VOP_SENDFILE(vp, filp, ppos, 0, count, actor, target, NULL, error); : return error; : } : : (note error is int, not ssize_t), but I don't see anything obvious : for other filesystems. : Yes, XFS. I will look at it in the evening. Thanks, -Yenya -- | Jan "Yenya" Kasprzak | | GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E | | http://www.fi.muni.cz/~kas/ Czech Linux Homepage: http://www.linux.cz/ | Any compiler or language that likes to hide things like memory allocations behind your back just isn't a good choice for a kernel. --Linus Torvalds