From: Andi Kleen <ak@muc.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jan Kasprzak <kas@informatics.muni.cz>, Andi Kleen <ak@muc.de>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: sendfile -EOVERFLOW on AMD64
Date: 19 May 2004 14:44:27 +0200 [thread overview]
Date: Wed, 19 May 2004 14:44:27 +0200 [thread overview]
Message-ID: <20040519124427.GA68902@colin2.muc.de> (raw)
In-Reply-To: <20040519105805.GK30909@devserv.devel.redhat.com>
> (note error is int, not ssize_t), but I don't see anything obvious
> for other filesystems.
sendfile64 on 32bit hosts seems to be quite fishy too.
It works with ssize_t, which is 32bit only, but there are no checks
that the transfered file is not >4GB. It would just wrap in this case.
It would be better to add such checks for 32bit hosts to sendfile64.
Or am I missing something?
-Andi
next prev parent reply other threads:[~2004-05-19 12:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1XuW9-3G0-23@gated-at.bofh.it>
2004-05-19 9:29 ` Andi Kleen
2004-05-19 10:38 ` Jan Kasprzak
2004-05-19 10:58 ` Jakub Jelinek
2004-05-19 11:01 ` Jan Kasprzak
2004-05-19 11:22 ` Nathan Scott
2004-05-19 11:13 ` Nathan Scott
2004-05-19 12:44 ` Andi Kleen [this message]
2004-05-19 12:50 ` Jakub Jelinek
2004-05-19 12:57 ` Andi Kleen
2004-05-19 19:48 ` Jan Kasprzak
2004-05-19 8:44 Jan Kasprzak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040519124427.GA68902@colin2.muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=jakub@redhat.com \
--cc=kas@informatics.muni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®