From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@zip.com.au>
Subject: swsusp: fix devfs breakage introduced in 2.6.6
Date: Fri, 21 May 2004 13:05:00 +0200 [thread overview]
Message-ID: <20040521110459.GA2529@elf.ucw.cz> (raw)
Hi!
This fixes bad interaction between devfs and swsusp.
Check whether the swap device is the specified resume
device, irrespective of whether they are specified by
identical names.
(Thus, device inode aliasing is allowed. You can say
/dev/hda4 instead of /dev/ide/host0/bus0/target0/lun0/part4
[if using devfs] and they'll be considered the same device.
This is *necessary* for devfs, since the resume code can
only recognize the form /dev/hda4, but the suspend code
would like the long name [as shown in 'cat /proc/mounts'].)
[Thanks to devfs hero whose name I forgot.]
Pavel
--- clean/kernel/power/swsusp.c 2004-05-20 23:08:36.000000000 +0200
+++ linux/kernel/power/swsusp.c 2004-05-21 12:26:43.000000000 +0200
@@ -222,10 +224,30 @@
__free_page(page);
}
+
+/*
+ * Check whether the swap device is the specified resume
+ * device, irrespective of whether they are specified by
+ * identical names.
+ *
+ * (Thus, device inode aliasing is allowed. You can say /dev/hda4
+ * instead of /dev/ide/host0/bus0/target0/lun0/part4 [if using devfs]
+ * and they'll be considered the same device. This is *necessary* for
+ * devfs, since the resume code can only recognize the form /dev/hda4,
+ * but the suspend code would see the long name.)
+ */
+static int is_resume_device(const struct swap_info_struct *swap_info)
+{
+ struct file *file = swap_info->swap_file;
+ struct inode *inode = file->f_dentry->d_inode;
+
+ return S_ISBLK(inode->i_mode) &&
+ resume_device == MKDEV(imajor(inode), iminor(inode));
+}
+
static void read_swapfiles(void) /* This is called before saving image */
{
int i, len;
- static char buff[sizeof(resume_file)], *sname;
len=strlen(resume_file);
root_swap = 0xFFFF;
@@ -244,17 +266,10 @@
swapfile_used[i] = SWAPFILE_IGNORED;
} else {
/* we ignore all swap devices that are not the resume_file */
- sname = d_path(swap_info[i].swap_file->f_dentry,
- swap_info[i].swap_file->f_vfsmnt,
- buff,
- sizeof(buff));
- if (!strcmp(sname, resume_file)) {
+ if (is_resume_device(&swap_info[i])) {
swapfile_used[i] = SWAPFILE_SUSPEND;
root_swap = i;
} else {
-#if 0
- printk( "Resume: device %s (%x != %x) ignored\n", swap_info[i].swap_file->d_name.name, swap_info[i].swap_device, resume_device );
-#endif
swapfile_used[i] = SWAPFILE_IGNORED;
}
}
--
934a471f20d6580d5aad759bf0d97ddc
next reply other threads:[~2004-05-21 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-21 11:05 Pavel Machek [this message]
2004-05-21 18:05 Sau Dan Lee
2004-05-21 18:44 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040521110459.GA2529@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®