From: viro@parcelfarce.linux.theplanet.co.uk
To: "Spinka, Kristofer" <kspinka@style.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Unserializing ioctl() system calls
Date: Sat, 22 May 2004 03:54:00 +0100 [thread overview]
Message-ID: <20040522025400.GU17014@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <web-1649994@style.net>
On Fri, May 21, 2004 at 10:46:45PM -0400, Spinka, Kristofer wrote:
> I noticed that even in the 2.6.6 code, callers to ioctl
> system call (sys_ioctl in fs/ioctl.c) are serialized with
> {lock,unlock}_kernel().
>
> I realize that many kernel modules, and POSIX for that
> matter, may not be ready to make this more concurrent.
>
> I propose adding a flag to indicate that the underlying
> module would like to support its own concurrency
> management, and thus we avoid grabbing the BKL around the
> f_op->ioctl call.
>
> The default behavior would adhere to existing standards,
> and if the flag is present (in the underlying module), we
> let the module (or modules) handle it.
>
> Reasonable?
No. Flags on drivers are never a good idea. What's more, if somebody
wants that shit parallelized they can always drop BKL upon entry and
reacquire on exit from their ->ioctl().
next prev parent reply other threads:[~2004-05-22 2:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-22 2:46 Spinka, Kristofer
2004-05-22 2:54 ` viro [this message]
2004-05-22 3:35 ` Spinka, Kristofer
[not found] <1YuKj-2FZ-9@gated-at.bofh.it>
2004-05-22 8:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040522025400.GU17014@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=kspinka@style.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®