From: Ingo Oeser <ioe-lkml@rameria.de>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Jakub Jelinek <jakub@redhat.com>,
mingo@redhat.com
Subject: Re: [PATCH] Add FUTEX_CMP_REQUEUE futex op
Date: Sat, 22 May 2004 12:10:58 +0200 [thread overview]
Message-ID: <200405221211.00938.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20040521160510.4214c7a3.akpm@osdl.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Saturday 22 May 2004 01:05, Andrew Morton wrote:
> You've added an smp_mb(). These things are becoming like lock_kernel() -
> hard for the reader to discern what it's protecting against.
>
> Please always include a comment when adding a barrier like this.
What about including this in the API?
sth. like
#define smp_mb(why) do { \
static __debugdata__ char __lock_reason[] = why; \
} while(0)
would be sufficient. __debugdata__ section
will then be stripped from compressed image but not vmlinux.
Is there another way to force developers to comment? ;-)
Regards
Ingo Oeser
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFArycyU56oYWuOrkARAljxAKDNE04H2/zr+rZcu1SAR3x19rUtHgCgwqKV
+Mpszd42hQ7hDQjphDobNRk=
=gh0g
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2004-05-22 15:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-20 9:38 Jakub Jelinek
2004-05-20 22:52 ` Andrew Morton
2004-05-21 6:06 ` Ulrich Drepper
2004-05-21 6:36 ` Andrew Morton
2004-05-21 7:15 ` Ulrich Drepper
2004-05-21 7:43 ` Jakub Jelinek
2004-05-22 16:58 ` Arnd Bergmann
2004-05-24 7:34 ` Jakub Jelinek
2004-05-24 8:12 ` Andrew Morton
2004-05-24 8:19 ` Jakub Jelinek
2004-05-28 13:09 ` DOCUMENTATION " bert hubert
2004-05-28 14:02 ` Jakub Jelinek
2004-05-28 15:39 ` bert hubert
2004-05-24 8:27 ` bert hubert
2004-05-24 17:34 ` Arnd Bergmann
2004-05-21 7:05 ` Ingo Molnar
2004-05-21 23:05 ` Andrew Morton
2004-05-22 10:10 ` Ingo Oeser [this message]
2004-05-23 17:33 ` Jakub Jelinek
2004-05-29 3:13 ` Rusty Russell
2004-06-07 16:03 Martin Schwidefsky
[not found] <mailman.1086629984.12568.linux-kernel2news@redhat.com>
2004-06-09 20:04 ` Pete Zaitcev
2004-06-09 22:08 ` Arnd Bergmann
2004-06-11 8:35 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405221211.00938.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=akpm@osdl.org \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®