mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Andrew Morton <akpm@osdl.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	David Woodhouse <dwmw2@infradead.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	l.s.r@web.de, Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] 2.6.6-mm5: JFFS2_FS_NAND=y compile error
Date: Sat, 22 May 2004 14:19:05 +0200	[thread overview]
Message-ID: <20040522121905.GM18564@fs.tum.de> (raw)
In-Reply-To: <20040522013636.61efef73.akpm@osdl.org>

The patch
  [PATCH] trivial: Make JFFS2 ready for Linux 2.7
from Linus' tree is broken with CONFIG_JFFS2_FS_NAND=y:

<--  snip  -->

...
  LD      .tmp_vmlinux1
fs/built-in.o(.text+0x16bdc2): In function `jffs2_wbuf_recover':
: undefined reference to `jffs2_erase_pending_trigger'
fs/built-in.o(.text+0x16c0e2): In function `jffs2_wbuf_recover':
: undefined reference to `jffs2_reserve_space_gc'
fs/built-in.o(.text+0x16c198): In function `jffs2_wbuf_recover':
: undefined reference to `jffs2_alloc_raw_node_ref'
fs/built-in.o(.text+0x16c1d0): In function `jffs2_wbuf_recover':
: undefined reference to `jffs2_add_physical_node_ref'
fs/built-in.o(.text+0x16c46b): In function `jffs2_wbuf_recover':
: undefined reference to `jffs2_erase_pending_trigger'
fs/built-in.o(.text+0x16c8f9): In function `__jffs2_flush_wbuf':
: undefined reference to `jffs2_erase_pending_trigger'
fs/built-in.o(.text+0x16c9f3): In function `jffs2_flush_wbuf_gc':
: undefined reference to `jffs2_garbage_collect_pass'
fs/built-in.o(.text+0x16cac8): In function `jffs2_flash_writev':
: undefined reference to `jffs2_flash_direct_writev'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


The bug is obvious, and the fix is trivial:


--- linux-2.6.6-mm5-full/fs/jffs2/Makefile.old	2004-05-22 14:15:47.000000000 +0200
+++ linux-2.6.6-mm5-full/fs/jffs2/Makefile	2004-05-22 14:16:30.000000000 +0200
@@ -12,4 +12,4 @@
 jffs2-y	+= symlink.o build.o erase.o background.o fs.o writev.o
 jffs2-y	+= super.o
 
-jffs2-$(CONFIG_JFFS2_FS_NAND)	:= wbuf.o
+jffs2-$(CONFIG_JFFS2_FS_NAND)	+= wbuf.o



cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2004-05-22 12:19 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-22  8:36 2.6.6-mm5 Andrew Morton
2004-05-22  9:09 ` 2.6.6-mm5 Jeff Garzik
2004-05-22  9:22   ` 2.6.6-mm5 hch
2004-05-22  9:26     ` 2.6.6-mm5 Andrew Morton
2004-05-22 11:51   ` 2.6.6-mm5 R. J. Wysocki
2004-05-22  9:26 ` 2.6.6-mm5 hch
2004-05-22  9:32   ` 2.6.6-mm5 Andrew Morton
2004-05-22  9:41     ` 2.6.6-mm5 hch
2004-05-22 19:03       ` 2.6.6-mm5 Brian King
2004-05-22  9:38 ` 2.6.6-mm5 hch
2004-05-22  9:44   ` 2.6.6-mm5 Jens Axboe
2004-05-22  9:46 ` 2.6.6-mm5 Felipe Alfaro Solana
2004-05-23 15:51   ` 2.6.6-mm5 James Morris
2004-05-22 11:59 ` 2.6.6-mm5 Matthias Andree
2004-05-22 12:19 ` Adrian Bunk [this message]
2004-05-23  1:01 ` 2.6.6-mm5 Eric W. Biederman
2004-05-23  1:08   ` 2.6.6-mm5 Andrew Morton
2004-05-23  1:15     ` 2.6.6-mm5 Roland Dreier
2004-05-24 16:17       ` 2.6.6-mm5 Matt Mackall
2004-05-24 17:03         ` 2.6.6-mm5 Eric W. Biederman
2004-05-24 17:43           ` 2.6.6-mm5 Roland Dreier
2004-05-25  7:25             ` 2.6.6-mm5 Eric W. Biederman
2004-05-23  2:45     ` 2.6.6-mm5 Eric W. Biederman
2004-05-24 22:11 ` 2.6.6-mm5 (compile stats) John Cherry
2004-05-25 13:53 ` 2.6.6-mm5 Pavel Machek
2004-05-26 12:41 ` 2.6.6-mm5 Anders Gustafsson
2004-05-26 12:49   ` 2.6.6-mm5 Jens Axboe
2004-05-26 12:59     ` 2.6.6-mm5 Anders Gustafsson
2004-05-26 13:03       ` 2.6.6-mm5 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040522121905.GM18564@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=akpm@osdl.org \
    --cc=dwmw2@infradead.org \
    --cc=l.s.r@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®