mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: hugh@veritas.com, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] export swapper_space
Date: Sun, 23 May 2004 16:04:39 -0700	[thread overview]
Message-ID: <20040523160439.0aad94a2.akpm@osdl.org> (raw)
In-Reply-To: <1085352637.10930.42.camel@mulgrave>

James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> This is now used as part of the page_mapping() macro.  However, certain
> filesystems, such as ext3, make use of this.  If it's not exported, they
> can't be compiled as modules.

I'd be a bit reluctant to do this.  filesystems actually have no need for
page_mapping() - page->mapping is always correct in that context and
page_mapping() has additional overhead.  So if poss we should avoid this
export so as to force filesystems to avoid page_mapping().

parisc broke because its flush_dcache_page() is inlined, and it uses
page_mapping().  I'd suggest that parisc and arm uninline that function -
it's quite large anyway.



  parent reply	other threads:[~2004-05-23 23:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-23 22:50 James Bottomley
2004-05-23 23:03 ` hch
2004-05-23 23:04 ` Andrew Morton [this message]
2004-05-23 23:12   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040523160439.0aad94a2.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=James.Bottomley@SteelEye.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®