From: Andrew Morton <akpm@osdl.org>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: linux-kernel@vger.kernel.org, mason@suse.com
Subject: Re: [FIX] kernel BUG at fs/locks.c:1723!
Date: Mon, 24 May 2004 00:38:03 -0700 [thread overview]
Message-ID: <20040524003803.3cb476db.akpm@osdl.org> (raw)
In-Reply-To: <200405232350.16169.agruen@suse.de>
Andreas Gruenbacher <agruen@suse.de> wrote:
>
>
> There is a race between unshare_files() and the following steal_locks(). As a
> consequence, steal_locks() may steal some additional FL_POSIX locks that
> don't belong to the current thread. This triggers a BUG in
> locks_remove_flock().
Well based on Trond's words it's not clear whether we should be proceeding
this way. Although I think he said "the code is crap and someone should
rewrite it". Fine, but that doesn't mean we shouldn't be fixing oopses in
the current stuff.
I fixed up the big reject which this threw - it's getting a bit optimistic
sending out patches against 2.6.5...
prev parent reply other threads:[~2004-05-24 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-23 21:50 Andreas Gruenbacher
2004-05-23 22:51 ` Trond Myklebust
2004-05-24 7:38 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040524003803.3cb476db.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=agruen@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®