From: "Randy.Dunlap" <rddunlap@osdl.org>
To: "Benoît Dejean" <TazForEver@free.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] typo in drivers/usb/class/usblp.c (resend)
Date: Mon, 24 May 2004 11:34:28 -0700 [thread overview]
Message-ID: <20040524113428.4012a736.rddunlap@osdl.org> (raw)
In-Reply-To: <1085393489.6815.30.camel@athlon>
On Mon, 24 May 2004 12:11:29 +0200 Benoît Dejean wrote:
| i think there's a typo error in usblp.c
|
| patch against 2.6.6
|
| --- linux-2.6.6/drivers/usb/class/usblp.c 2004-04-04
| 05:36:26.000000000
| +0200
| +++ linux-2.6.6-modified/drivers/usb/class/usblp.c 2004-05-24
| 01:15:20.000000000 +0200
| @@ -305,7 +305,7 @@
|
| if (~status & LP_PERRORP)
| newerr = 3;
| - if (status & LP_POUTPA)
| + if (~status & LP_POUTPA)
| newerr = 1;
| if (~status & LP_PSELECD)
| newerr = 2;
| --
Why do you think that there is a typo? Did you check the USB
printer specification?
LP_PERRORP == 0 means Error.
LP_PSELECD == 0 means Not Selected (or means User disabled the printer).
LP_POUTPA == 1 means Paper Empty.
See, LP_POUTPA has different error polarity than the other bits.
I don't see a problem. Are you experiencing some problem with
a USB printer?
--
~Randy
next prev parent reply other threads:[~2004-05-24 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-24 10:11 Benoît Dejean
2004-05-24 18:34 ` Randy.Dunlap [this message]
[not found] <mailman.1085393760.20566.linux-kernel2news@redhat.com>
2004-05-25 0:23 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040524113428.4012a736.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=TazForEver@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®