From: Andrew Morton <akpm@osdl.org>
To: Alexander Nyberg <alexn@telia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] msync shouldn't go over bss sections
Date: Mon, 24 May 2004 13:43:14 -0700 [thread overview]
Message-ID: <20040524134314.508bd514.akpm@osdl.org> (raw)
In-Reply-To: <1085408042.27361.17.camel@boxen>
Alexander Nyberg <alexn@telia.com> wrote:
>
> This changes the behaviour of msync_interval() to make it impossible to
> try to sys_msync() anything not file mapped.
>
Well the patch doesn't "make it impossible". It makes it return -ENOMEM.
>From my reading of the spec your patch converts correct behaviour to
incorrect behaviour, and even if that's untrue, I think we're stuck with
the current behaviour - this change can break current applications.
> --- mm/msync_orig.c 2004-05-23 21:31:32.000000000 +0200
> +++ mm/msync.c 2004-05-24 16:10:24.000000000 +0200
> @@ -137,7 +137,7 @@ static int filemap_sync(struct vm_area_s
> static int msync_interval(struct vm_area_struct * vma,
> unsigned long start, unsigned long end, int flags)
> {
> - int ret = 0;
> + int ret = -ENOMEM;
> struct file * file = vma->vm_file;
>
> if ((flags & MS_INVALIDATE) && (vma->vm_flags & VM_LOCKED))
prev parent reply other threads:[~2004-05-24 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-24 14:14 Alexander Nyberg
2004-05-24 20:43 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040524134314.508bd514.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alexn@telia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®