From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263979AbUEXFwq (ORCPT ); Mon, 24 May 2004 01:52:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264057AbUEXFwq (ORCPT ); Mon, 24 May 2004 01:52:46 -0400 Received: from mail012.syd.optusnet.com.au ([211.29.132.66]:29402 "EHLO mail012.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S263979AbUEXFwo (ORCPT ); Mon, 24 May 2004 01:52:44 -0400 From: "Cef (LKML)" To: linux-kernel@vger.kernel.org Subject: Re: [announce/OT] kerneltop ver. 0.7 Date: Mon, 24 May 2004 15:53:42 +1000 User-Agent: KMail/1.6.2 Cc: "Randy.Dunlap" References: <20040523215027.5dc99711.rddunlap@osdl.org> In-Reply-To: <20040523215027.5dc99711.rddunlap@osdl.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200405241553.44114.cef-lkml@optusnet.com.au> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 May 2004 14:50, Randy.Dunlap wrote: > just a little note about kerneltop... > > 'kerneltop' is similar to 'top', but shows only kernel function usage > (modules not included). Looks good! A few suggestions.... Might want to add support for /boot/System.map containing the version number (eg: /boot/System.map-`uname -r` ), if /boot/System.map doesn't exist, before just dropping out with an error. For clarity, you might want to invert the "address function ....." line to separate the header from the actual displayed data (like top does). Having the total up in the header instead of at the end of the data might also be useful (eg: next to ticks perhaps?) as it's really a waste of a display line for 1 number. Also a little more verbosity in the error messages would be good. eg: /proc/profile not found: You need to enable profiling support in your kernel to use kerneltop /proc/profile Permission Denied: You need to be root to run kerneltop Hope these comments are useful. -- Stuart Young (aka Cef) cef-lkml@optusnet.com.au is for LKML and related email only