mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAP_POPULATE prot 0
Date: Mon, 24 May 2004 23:13:55 +0200	[thread overview]
Message-ID: <20040524211355.GA16165@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.44.0405242003270.27145-100000@localhost.localdomain>


* Hugh Dickins <hugh@veritas.com> wrote:

> It seems eccentric to implement MAP_POPULATE only on PROT_NONE
> mappings: do_mmap_pgoff is passing down prot, then
> sys_remap_file_pages verifies it's not set.  I guess that's an
> oversight from when we realized that the prot arg to
> sys_remap_file_pages was misdesigned.

yeah.

> There's another oddity whose heritage is harder for me to understand,
> so please let me leave it to you: sys_remap_file_pages is declared as
> asmlinkage in mm/fremap.c, but is the one syscall declared without
> asmlinkage in include/linux/syscalls.h.

i think that's just an oversight.

	Ingo

      reply	other threads:[~2004-05-24 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-24 19:06 Hugh Dickins
2004-05-24 21:13 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040524211355.GA16165@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®