From: Colin Leroy <colin@colino.net>
To: benh@kernel.crashing.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] (2.6.7-rc1) ADB driver fails to create /dev/adb
Date: Tue, 25 May 2004 22:29:29 +0200 [thread overview]
Message-ID: <20040525222929.4e31cc19@jack.colino.net> (raw)
In-Reply-To: <20040525214504.377f3f12@jack.colino.net>
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
On 25 May 2004 at 21h05, Colin Leroy wrote:
Hi,
> Here's a patch that restores previous behaviour. (I bothered because I
> noticed lots of other drivers still using devfs_mk_cdev() and I think
> it should stay here for a bit more).
Mmh, here's a nicer patch (forgot a return, and the else isn't the most
clear).
--
Colin
[-- Attachment #2: adb.c.patch --]
[-- Type: text/plain, Size: 538 bytes --]
--- drivers/macintosh/adb.c.orig 2004-05-25 21:08:10.000000000 +0200
+++ drivers/macintosh/adb.c 2004-05-25 22:27:04.596656712 +0200
@@ -899,6 +899,11 @@
if (register_chrdev(ADB_MAJOR, "adb", &adb_fops)) {
printk(KERN_ERR "adb: unable to get major %d\n", ADB_MAJOR);
return;
+ }
+ if (devfs_mk_cdev(MKDEV(ADB_MAJOR, 0),
+ S_IFCHR | S_IRUSR | S_IWUSR, "adb")) {
+ printk(KERN_ERR "adb: unable to make dev via devfs\n");
+ return;
}
adb_dev_class = class_simple_create(THIS_MODULE, "adb");
if (IS_ERR(adb_dev_class)) {
prev parent reply other threads:[~2004-05-25 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-25 19:45 Colin Leroy
2004-05-25 20:29 ` Colin Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040525222929.4e31cc19@jack.colino.net \
--to=colin@colino.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®