From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Larry McVoy <lm@work.bitmover.com>, Andrew Morton <akpm@osdl.org>,
Larry McVoy <lm@bitmover.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFD] Explicitly documenting patch submission
Date: Thu, 27 May 2004 17:18:45 +0200 [thread overview]
Message-ID: <20040527151845.GH23194@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20040527145127.GB3375@work.bitmover.com>
On Thu, 27 May 2004 07:51:27 -0700, Larry McVoy wrote:
>
> I think we can have our cake and eat it too, at least in BK (and there
> is no reason other systems couldn't do this as well): BK does not have
> the concept of a 1:1 binding between a change to a file and a changeset.
> A changeset is a container which may have one or more deltas to one or
> more files, i.e., it is many:1.
>
> If you took to sending your patches as the original patch plus another
> patch, bundling them together (I can work out a format and GPLed tools for
> this) then what we could do is have the BK import tools record the first
> one as a set of deltas, the next one as another set of deltas, and so on.
> We can handle an arbitrary number of patches to patches to patches.
> Then when the import finishes we bundle up all the deltas in one logical
> changeset. 99% of the time people won't care about the details, when
> they are looking through the code the interfaces will all work as they
> do today, the BK/Web interface would export this as a patch just like
> you are used to, but when people do care the full information is there.
Sounds good, as long as it is simple (read: simplest) to read and
export the result of everything as one patch. I.e. I wouldn't want to
see this:
@@ -28,6 +28,7 @@
+ /* new comment in empty raea */
@@ -28,67+28,7 @@
- /* new comment in empty raea */
+ /* new comment in empty area */
But that goes without saying, doesn't it? ;)
> I suspect that with a little practice this could be quite useful.
> I could build tools which record the secondary patches as diffs to
> the patches (I think) and if you have ever read a diff of a diff
> it is suprisingly useful. I tend to save diffs of my work in
> progress and then later I'll generate diffs again and diff them to
> get my context back.
Diffs to diffs I am even less eager to read. As an internal format,
they make sense, though.
Jörn
--
There's nothing better for promoting creativity in a medium than
making an audience feel "Hmm I could do better than that!"
-- Douglas Adams in a slashdot interview
next prev parent reply other threads:[~2004-05-27 15:19 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-27 6:20 Larry McVoy
2004-05-27 8:04 ` Andrew Morton
2004-05-27 14:51 ` Larry McVoy
2004-05-27 15:18 ` Jörn Engel [this message]
2004-05-27 16:13 ` Jon Smirl
2004-05-27 21:09 ` La Monte H.P. Yarroll
2004-05-27 21:46 ` Theodore Ts'o
2004-05-28 13:24 ` Larry McVoy
2004-05-28 15:07 ` Theodore Ts'o
2004-05-28 15:19 ` Dave Jones
2004-05-28 15:27 ` Larry McVoy
2004-05-28 15:35 ` Dave Jones
2004-05-28 17:11 ` Theodore Ts'o
2004-05-28 17:16 ` Larry McVoy
2004-05-28 15:24 ` Larry McVoy
[not found] <A6974D8E5F98D511BB910002A50A6647615FD265@hdsmsx403.hd.intel.com>
2004-06-03 6:38 ` Len Brown
[not found] <20040525110000.27463.19462.Mailman@lists.us.dell.com>
2004-05-25 15:03 ` Justin Michael
[not found] <1ZBgK-68x-3@gated-at.bofh.it>
2004-05-25 6:43 ` Kai Henningsen
-- strict thread matches above, loose matches on Subject: below --
2004-05-24 23:05 Albert Cahalan
2004-05-25 3:50 ` Linus Torvalds
2004-05-25 19:28 ` Horst von Brand
[not found] <1YUY7-6fF-11@gated-at.bofh.it>
2004-05-24 19:57 ` Andi Kleen
2004-05-24 20:07 ` Davide Libenzi
2004-05-24 20:19 ` Joe Perches
2004-05-24 20:45 ` Linus Torvalds
2004-05-24 21:16 ` Davide Libenzi
2004-05-24 21:38 ` Linus Torvalds
2004-05-25 0:41 ` Francis J. A. Pinteric
2004-05-25 1:56 ` viro
2004-05-24 20:31 ` Linus Torvalds
2004-05-24 22:01 ` Andi Kleen
2004-05-24 22:14 ` Linus Torvalds
2004-05-24 20:50 ` Thomas Gleixner
2004-05-24 21:05 ` Linus Torvalds
2004-05-24 21:20 ` Thomas Gleixner
2004-06-10 8:00 ` Pavel Machek
2004-05-25 3:49 ` Matt Mackall
2004-05-25 4:02 ` Linus Torvalds
2004-05-25 11:11 ` Giuseppe Bilotta
2004-05-25 13:48 ` Steven Cole
2004-05-25 14:12 ` La Monte H.P. Yarroll
2004-05-24 21:19 ` Horst von Brand
2004-05-23 23:19 Shane Shrybman
2004-05-23 6:46 Linus Torvalds
2004-05-23 7:41 ` Neil Brown
2004-05-23 8:02 ` Arjan van de Ven
2004-05-23 15:25 ` Greg KH
2004-05-23 15:35 ` Arjan van de Ven
2004-05-23 15:42 ` Greg KH
2004-05-23 18:03 ` Matt Mackall
2004-05-23 15:38 ` Ian Stirling
2004-05-23 15:44 ` Greg KH
2004-05-23 16:01 ` Linus Torvalds
2004-05-23 15:53 ` Linus Torvalds
2004-05-23 16:33 ` Horst von Brand
2004-05-23 17:06 ` Linus Torvalds
2004-05-23 17:32 ` Roman Zippel
2004-05-23 17:55 ` Joe Perches
2004-05-23 19:00 ` Jeff Garzik
2004-05-23 19:12 ` Joe Perches
2004-05-23 21:41 ` Francois Romieu
2004-05-23 19:01 ` Davide Libenzi
2004-05-23 19:20 ` Linus Torvalds
2004-05-25 15:20 ` La Monte H.P. Yarroll
2004-05-25 21:16 ` H. Peter Anvin
2004-05-25 6:32 ` Daniel Phillips
2004-05-25 18:11 ` Paul Jackson
2004-05-25 7:06 ` Arjan van de Ven
2004-05-25 15:32 ` Steven Cole
2004-05-25 16:02 ` Bradley Hook
2004-05-25 18:51 ` La Monte H.P. Yarroll
2004-05-25 19:44 ` Bradley Hook
2004-05-26 4:16 ` Daniel Phillips
2004-05-25 13:11 ` Ben Collins
2004-05-25 17:15 ` Linus Torvalds
2004-05-25 17:18 ` Ben Collins
2004-05-25 18:02 ` Dave Jones
2004-05-25 18:06 ` Ben Collins
2004-05-25 18:51 ` Linus Torvalds
2004-05-25 15:00 ` raven
2004-05-25 15:44 ` La Monte H.P. Yarroll
2004-05-25 16:25 ` Linus Torvalds
2004-05-25 16:43 ` La Monte H.P. Yarroll
2004-05-25 17:40 ` Valdis.Kletnieks
2004-05-25 17:52 ` Linus Torvalds
2004-05-25 16:42 ` J. Bruce Fields
2004-05-25 17:05 ` Linus Torvalds
2004-05-25 18:08 ` Andy Isaacson
2004-05-25 20:10 ` Matt Mackall
2004-06-10 12:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040527151845.GH23194@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm@bitmover.com \
--cc=lm@work.bitmover.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®