From: Andrew Morton <akpm@osdl.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: jurjen@stupendous.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] 2.6.6 tty_io.c hangup locking
Date: Fri, 28 May 2004 16:06:12 -0700 [thread overview]
Message-ID: <20040528160612.306c22ab.akpm@osdl.org> (raw)
In-Reply-To: <1085769769.2106.23.camel@deimos.microgate.com>
Paul Fulghum <paulkf@microgate.com> wrote:
>
> The following patch removes unnecessary disabling of
> interrupts when processing hangup for tty devices.
Ho hum, this has been hanging around forever. Obviously the current
locking is pointless and the only useful locking we have in there is
lock_kernel().
The reason why a patch such as yours wasn't applied is that it was all kept
as a reminder that we suck. Someone needs to get down and audit what's
actually happening in there. It seems that you've now done that via
comparison with other callers, but that is not necessarily a good approach
when it comes to the tty layer ;)
We need to itemise all the affected memory storage in all impementations of
->flush_buffer() and ->write_wakeup() and then make sure that all _other_
users of those fields (whether or not they lie in the ->flush_buffer() and
->write_wakeup() codepaths) are using the same locking. Is that something
you could do?
next prev parent reply other threads:[~2004-05-28 23:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-27 17:45 Badness in local_bh_enable at kernel/softirq.c:122 Jurjen Oskam
2004-05-27 18:19 ` Jurjen Oskam
2004-05-27 20:41 ` Paul Fulghum
2004-05-28 18:42 ` [PATCH][RFC] 2.6.6 tty_io.c hangup locking Paul Fulghum
2004-05-28 20:11 ` Jurjen Oskam
2004-05-28 20:33 ` Paul Fulghum
2004-05-28 23:06 ` Andrew Morton [this message]
2004-05-29 17:45 ` Paul Fulghum
2004-06-01 20:51 ` [PATCH] 2.6.6 synclinkmp.c Paul Fulghum
2004-06-01 20:57 ` Russell King
2004-06-01 21:25 ` Paul Fulghum
2004-06-02 21:22 ` Russell King
2004-06-02 22:04 ` Paul Fulghum
2004-06-02 14:13 ` Paul Fulghum
2004-06-01 20:51 ` [PATCH] 2.6.6 synclink.c Paul Fulghum
2004-06-02 14:15 ` Paul Fulghum
2004-06-01 20:53 ` [PATCH] 2.6.6 synclink_cs.c Paul Fulghum
2004-06-01 21:00 ` Russell King
2004-06-01 23:04 ` Paul Fulghum
2004-06-13 9:05 ` [PATCH][RFC] 2.6.6 tty_io.c hangup locking Jurjen Oskam
2004-06-13 13:29 ` Paul Fulghum
2004-06-13 14:24 ` Jurjen Oskam
2004-06-13 14:39 ` Paul Fulghum
2004-06-13 15:05 Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040528160612.306c22ab.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jurjen@stupendous.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®