mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eugene Surovegin <ebs@ebshome.net>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: akpm@osdl.org, torvalds@osdl.org, mporter@kernel.crashing.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] ppc32: reorg DMA API, add coherent alloc in irq
Date: Sun, 30 May 2004 11:29:06 -0700	[thread overview]
Message-ID: <20040530182906.GA29666@gate.ebshome.net> (raw)
In-Reply-To: <1085920115.6882.1.camel@laptop.fenrus.com>

On Sun, May 30, 2004 at 02:28:35PM +0200, Arjan van de Ven wrote:
> On Sat, 2004-05-29 at 19:56, Linux Kernel Mailing List wrote:
> > ChangeSet 1.1770, 2004/05/29 10:56:14-07:00, akpm@osdl.org
> > 
> > 	[PATCH] ppc32: reorg DMA API, add coherent alloc in irq
> > 	
> > 	From: Matt Porter <mporter@kernel.crashing.org>
> 
> this breaks the acenic driver:
> 
> In file included from drivers/net/acenic.c:186:
> drivers/net/acenic.h:598: error: syntax error before
> "DECLARE_PCI_UNMAP_ADDR"

[snip]

This patch should help.

PPC32: Put back DECLARE_PCI_UNMAP_??? and friends accidentaly removed during DMA 
API reorganization.

Signed-off-by: Eugene Surovegin <ebs@ebshome.net>

===== include/asm-ppc/pci.h 1.28 vs edited =====
--- 1.28/include/asm-ppc/pci.h	Sat May 29 00:26:35 2004
+++ edited/include/asm-ppc/pci.h	Sun May 30 11:03:59 2004
@@ -61,6 +61,14 @@
  */
 #define PCI_DMA_BUS_IS_PHYS     (1)
 
+/* pci_unmap_{page,single} is a nop so... */
+#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)
+#define DECLARE_PCI_UNMAP_LEN(LEN_NAME)
+#define pci_unmap_addr(PTR, ADDR_NAME)		(0)
+#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL)	do { } while (0)
+#define pci_unmap_len(PTR, LEN_NAME)		(0)
+#define pci_unmap_len_set(PTR, LEN_NAME, VAL)	do { } while (0)
+
 /*
  * At present there are very few 32-bit PPC machines that can have
  * memory above the 4GB point, and we don't support that.



  reply	other threads:[~2004-05-30 18:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200405291908.i4TJ8a5l011479@hera.kernel.org>
2004-05-30 12:28 ` Arjan van de Ven
2004-05-30 18:29   ` Eugene Surovegin [this message]
2004-05-30 22:08     ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040530182906.GA29666@gate.ebshome.net \
    --to=ebs@ebshome.net \
    --cc=akpm@osdl.org \
    --cc=arjanv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=mporter@kernel.crashing.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®