Re: Resume enhancement: restore pci config space

[Jan-Benedict Glaw <jbglaw@lug-owl.de>]

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

On Sun, 2004-05-30 20:40:31 +0200, Pavel Machek <pavel@ucw.cz>
wrote in message <20040530184031.GF997@openzaurus.ucw.cz>:
> > One can rightfully argue that the driver resume method should do this, and
> > yes that is right. So the patch only does it for devices that don't have a
> > resume method. Like the main PCI bridge on my testbox of which the bios so
> > nicely forgets to restore the bus master bit during resume.. With this patch
> > my testbox resumes just fine while it, well, wasn't all too happy as you can
> > imagine without a busmaster pci bridge.

All that reminds me... The PCI subsystem should probably record any PCI
device's initial configuration state after boot-up and restore those
settings before system reboot. Code like that was already in place
(during 2.2.x cycle IIRC) for Alphas, but got lost somewhen (and was
never added again). Upon reboot, Alphas (with current 2.6.x) running SRM
firmware might crash horribly because of "misconfigured" PCI devices.

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]