From: Andrew Morton <akpm@osdl.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, bilotta78@hotpop.com,
danlee@informatik.uni-freiburg.de, vojtech@suse.cz,
tuukkat@ee.oulu.fi
Subject: Re: [RFC/RFT] Raw access to serio ports (1/2)
Date: Wed, 2 Jun 2004 00:46:54 -0700 [thread overview]
Message-ID: <20040602004654.648132f8.akpm@osdl.org> (raw)
In-Reply-To: <200406020243.09560.dtor_core@ameritech.net>
Dmitry Torokhov <dtor_core@ameritech.net> wrote:
>
> > The return values here are mucked up - this function returns `written'.
>
> Or an error code in negative notation - it's the standard practice for
> read/write. Am I missing something?
You want the function to return -ENODEV if !list->rawdev->serio
if (!list->rawdev->serio) {
retval = -ENODEV;
goto out;
}
...
out:
up(&rawdev_sem);
return written;
}
But it won't.
next prev parent reply other threads:[~2004-06-02 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 7:18 Dmitry Torokhov
2004-06-02 7:36 ` Andrew Morton
2004-06-02 7:43 ` Dmitry Torokhov
2004-06-02 7:46 ` Andrew Morton [this message]
2004-06-02 7:49 ` Dmitry Torokhov
2004-06-03 5:45 ` Dmitry Torokhov
2004-06-03 6:26 ` Sau Dan Lee
2004-06-03 6:38 ` Dmitry Torokhov
2004-06-05 7:31 ` [RFC/RFT] Raw access to serio ports (1/2) - take 3 Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040602004654.648132f8.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bilotta78@hotpop.com \
--cc=danlee@informatik.uni-freiburg.de \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tuukkat@ee.oulu.fi \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®