From: Andrew Morton <akpm@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davidc@debian.org, 252391@bugs.debian.org, linux-kernel@vger.kernel.org
Subject: Re: Bug#252391: kernel-source-2.6.6: Assertion failure in journal_flush() ... "!journal->j_running_transaction"
Date: Thu, 3 Jun 2004 21:30:39 -0700 [thread overview]
Message-ID: <20040603213039.359697c3.akpm@osdl.org> (raw)
In-Reply-To: <20040603114029.GA7912@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Andrew, what's stopping a journal_start() from setting j_running_transaction
> just before the last spin_lock(&journal->j_state_lock) that guards the
> J_ASSERT that was hit below?
Not much, it appears. I'll queue the below for post-2.6.7.
--- 25/fs/ext3/super.c~ext3-journal_flush-needs-journal_lock_updates 2004-06-03 21:15:57.911628872 -0700
+++ 25-akpm/fs/ext3/super.c 2004-06-03 21:15:57.916628112 -0700
@@ -1907,13 +1907,17 @@ static void ext3_commit_super (struct su
static void ext3_mark_recovery_complete(struct super_block * sb,
struct ext3_super_block * es)
{
- journal_flush(EXT3_SB(sb)->s_journal);
+ journal_t *journal = EXT3_SB(sb)->s_journal;
+
+ journal_lock_updates(journal);
+ journal_flush(journal);
if (EXT3_HAS_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER) &&
sb->s_flags & MS_RDONLY) {
EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER);
sb->s_dirt = 0;
ext3_commit_super(sb, es, 1);
}
+ journal_unlock_updates(journal);
}
/*
_
prev parent reply other threads:[~2004-06-04 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040603034037.70176BA0E0@zona.someotherplace.org>
2004-06-03 11:40 ` Herbert Xu
2004-06-04 4:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040603213039.359697c3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=252391@bugs.debian.org \
--cc=davidc@debian.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®