From: Pete Zaitcev <zaitcev@redhat.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Memory leak in visor.c and ftdi_sio.c
Date: Fri, 4 Jun 2004 11:04:14 -0700 [thread overview]
Message-ID: <20040604110414.4f6b407a.zaitcev@redhat.com> (raw)
In-Reply-To: <c9q8a6$hga$1@sea.gmane.org>
On Fri, 04 Jun 2004 17:34:41 +0100
Ian Abbott <abbotti@mev.co.uk> wrote:
> I made the original change to ftdi_sio.c to allocate the write urbs
> and their transfer buffers dynamically (instead of using a
> preallocated pool) and I copied that technique from visor.c!
>
> A related problem with the current implementation is that is easy to
> run out of memory by running something similar to this:
>
> # cat /dev/zero > /dev/ttyUSB0
This begs the question why in the world you discarded the
perfectly good code and went into the trouble of programming
the dynamic allocation scheme (with the leak we just plugged).
-- Pete
next prev parent reply other threads:[~2004-06-04 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-04 14:59 nardelli
2004-06-04 16:34 ` Ian Abbott
2004-06-04 17:25 ` nardelli
2004-06-04 18:04 ` Pete Zaitcev [this message]
2004-06-04 23:16 ` [linux-usb-devel] " Peter Horton
2004-06-05 0:18 ` Greg KH
2004-06-07 9:58 ` Ian Abbott
2004-06-07 14:19 ` nardelli
2004-06-07 15:43 ` Richard B. Johnson
2004-06-07 15:56 ` nardelli
2004-06-04 18:12 ` Greg KH
2004-06-04 18:47 ` nardelli
2004-06-04 22:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040604110414.4f6b407a.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=abbotti@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®