From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Yury Umanets <torque@ukrpost.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.6 memory allocation checks in cs46xx_dsp_proc_register_scb_desc()
Date: Sun, 6 Jun 2004 10:20:48 -0700 [thread overview]
Message-ID: <20040606102048.1b05c172.rddunlap@osdl.org> (raw)
In-Reply-To: <1086537990.2793.68.camel@firefly>
On Sun, 06 Jun 2004 19:06:42 +0300 Yury Umanets wrote:
| Adds memory allocation checks in cs46xx_dsp_proc_register_scb_desc()
|
| ./linux-2.6.6-modified/sound/pci/cs46xx/dsp_spos_scb_lib.c | 3 +++
| 1 files changed, 3 insertions(+)
|
| diff -rupN ./linux-2.6.6/sound/pci/cs46xx/dsp_spos_scb_lib.c
| ./linux-2.6.6-modified/sound/pci/cs46xx/dsp_spos_scb_lib.c
| --- ./linux-2.6.6/sound/pci/cs46xx/dsp_spos_scb_lib.c Mon May 10
| 05:33:20 2004
| +++ ./linux-2.6.6-modified/sound/pci/cs46xx/dsp_spos_scb_lib.c Wed Jun
| 2 14:57:41 2004
| @@ -246,6 +246,9 @@ void cs46xx_dsp_proc_register_scb_desc (
| if ((entry = snd_info_create_card_entry(ins->snd_card, scb->scb_name,
| ins->proc_dsp_dir)) != NULL) {
| scb_info = kmalloc(sizeof(proc_scb_info_t), GFP_KERNEL);
| + if (!scb_info)
| + return;
| +
| scb_info->chip = chip;
| scb_info->scb_desc = scb;
|
This seems to be missing some other cleanup on the failure path,
like it does below in the same function:
snd_info_free_entry(entry);
--
~Randy
next prev parent reply other threads:[~2004-06-06 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 16:06 Yury Umanets
2004-06-06 17:20 ` Randy.Dunlap [this message]
2004-06-06 17:40 ` Yury Umanets
2004-06-06 17:54 ` Yury Umanets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040606102048.1b05c172.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torque@ukrpost.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®