From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Yury Umanets <torque@ukrpost.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.6 memory allocation checks in drivers/pci/hotplug/shpchprm_acpi.c
Date: Sun, 6 Jun 2004 10:51:06 -0700 [thread overview]
Message-ID: <20040606105106.01c2fec9.rddunlap@osdl.org> (raw)
In-Reply-To: <1086538851.2793.90.camel@firefly>
On Sun, 06 Jun 2004 19:20:51 +0300 Yury Umanets wrote:
| Adds memory allocation checks in acpi_get__hpp()
|
| ./linux-2.6.6-modified/drivers/pci/hotplug/shpchprm_acpi.c | 2 ++
| 1 files changed, 2 insertions(+)
|
| Signed-off-by: Yury Umanets <torque@ukrpost.net>
|
| diff -rupN ./linux-2.6.6/drivers/pci/hotplug/shpchprm_acpi.c
| ./linux-2.6.6-modified/drivers/pci/hotplug/shpchprm_acpi.c
| --- ./linux-2.6.6/drivers/pci/hotplug/shpchprm_acpi.c Mon May 10
| 05:32:28 2004
| +++ ./linux-2.6.6-modified/drivers/pci/hotplug/shpchprm_acpi.c Wed Jun
| 2 14:28:07 2004
| @@ -218,6 +218,8 @@ static void acpi_get__hpp ( struct acpi_
| }
|
| ab->_hpp = kmalloc (sizeof (struct acpi__hpp), GFP_KERNEL);
| + if (!ab->_hpp)
| + goto free_and_return;
| memset(ab->_hpp, 0, sizeof(struct acpi__hpp));
|
| ab->_hpp->cache_line_size = nui[0];
|
| --
All other failure paths in this function use err() to inform the
console about what's happening... so flip a coin, I guess:
add a message or say that ACPI already has too many messages. :(
--
~Randy
next prev parent reply other threads:[~2004-06-06 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 16:20 Yury Umanets
2004-06-06 17:51 ` Randy.Dunlap [this message]
2004-06-07 15:52 ` Yury Umanets
2004-06-07 17:35 ` Luiz Fernando N. Capitulino
2004-06-08 6:14 ` Yury Umanets
2004-06-07 17:56 Sy, Dely L
2004-06-07 18:12 ` Greg KH
2004-06-07 18:27 Sy, Dely L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040606105106.01c2fec9.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torque@ukrpost.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®