From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: sboyce@blueyonder.co.uk
Cc: Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.7-rc2-mm1 (nforce2 lockup)
Date: Thu, 10 Jun 2004 16:51:23 -0600 [thread overview]
Message-ID: <200406101651.23895.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <40C2444B.4080403@blueyonder.co.uk>
Hi Sid,
Can you try the attached patch, please? I reproduced the problem on
my Proliant DL360, and this patch fixes it for me.
The problem was that drivers/serial/8250_acpi.c found COM1 in the
ACPI namespace and called acpi_register_gsi() to set up its IRQ.
ACPI tells us that the COM1 IRQ is edge triggered, active high,
but acpi_register_gsi() was ignoring the edge_level argument,
so it blindly set the COM1 IRQ to be level-triggered.
This is against 2.6.7-rc3-mm1.
diff -u -Nur linux-2.6.7-rc3-mm1.orig/arch/i386/kernel/acpi/boot.c linux-2.6.7-rc3-mm1/arch/i386/kernel/acpi/boot.c
--- linux-2.6.7-rc3-mm1.orig/arch/i386/kernel/acpi/boot.c 2004-06-10 16:26:55.000000000 -0600
+++ linux-2.6.7-rc3-mm1/arch/i386/kernel/acpi/boot.c 2004-06-10 16:30:22.000000000 -0600
@@ -451,10 +451,12 @@
static u16 irq_mask;
extern void eisa_set_level_irq(unsigned int irq);
- if ((gsi < 16) && !((1 << gsi) & irq_mask)) {
- Dprintk(KERN_DEBUG PREFIX "Setting GSI %u as level-triggered\n", gsi);
- irq_mask |= (1 << gsi);
- eisa_set_level_irq(gsi);
+ if (edge_level == ACPI_LEVEL_SENSITIVE) {
+ if ((gsi < 16) && !((1 << gsi) & irq_mask)) {
+ Dprintk(KERN_DEBUG PREFIX "Setting GSI %u as level-triggered\n", gsi);
+ irq_mask |= (1 << gsi);
+ eisa_set_level_irq(gsi);
+ }
}
}
#endif
next prev parent reply other threads:[~2004-06-10 22:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <A6974D8E5F98D511BB910002A50A6647615FD33E@hdsmsx403.hd.intel.com>
2004-06-04 21:45 ` Len Brown
2004-06-05 2:55 ` Sid Boyce
2004-06-05 4:00 ` Sid Boyce
2004-06-05 4:46 ` Len Brown
2004-06-06 18:50 ` Sid Boyce
2004-06-05 15:37 ` Bjorn Helgaas
2004-06-05 22:08 ` Sid Boyce
2004-06-10 22:51 ` Bjorn Helgaas [this message]
2004-06-11 1:07 ` Sid Boyce
2004-06-11 15:46 ` Sid Boyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406101651.23895.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyce@blueyonder.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®