mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.7-rc3-mm1
Date: Thu, 10 Jun 2004 21:36:59 -0700	[thread overview]
Message-ID: <20040610213659.0fd93039.pj@sgi.com> (raw)
In-Reply-To: <20040609015001.31d249ca.akpm@osdl.org>

Andrew,

Do you recall why your i386-uninline-bitops.patch moves i386
find_next_bit() and find_next_zero_bit() out of line, but not
find_first_zero_bit() nor find_first_bit()?

Text sizes - i386 optimized routine (decimal):
    find_next_zero_bit	132
    find_next_bit 	114
    find_first_zero_bit  76
    find_first_bit	 50

Uninlining find_first_bit() reduces my i386 kernel text size by 1336 bytes.

Uninlining find_first_zero_bit() is good for another 208 bytes.

Eh - perhaps this is too small potatoes to worry about now.

Or perhaps there was good reason to leave them inline all along.

Perhaps someone else has further insight to the tradeoffs here, such as
a 'recommended size', above which most routines should be not inlined,
except in special cases.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

  parent reply	other threads:[~2004-06-11  4:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-09  8:50 2.6.7-rc3-mm1 Andrew Morton
2004-06-09 11:25 ` 2.6.7-rc3-mm1 Eric BEGOT
2004-06-09 13:13   ` 2.6.7-rc3-mm1 Zwane Mwaikambo
2004-06-09 13:36     ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 13:42       ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 13:43       ` 2.6.7-rc3-mm1 Zwane Mwaikambo
2004-06-09 14:48         ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 14:58           ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 15:16             ` 2.6.7-rc3-mm1 William Lee Irwin III
     [not found]             ` <40C73198.4080700@yahoo.fr>
2004-06-09 15:50               ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 16:35 ` 2.6.7-rc3-mm1 Norberto Bensa
2004-06-09 17:05   ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 17:46     ` 2.6.7-rc3-mm1 Norberto Bensa
2004-06-10  3:38     ` 2.6.7-rc3-mm1 Norberto Bensa
2004-06-09 17:59 ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 19:50   ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 23:44 ` 2.6.7-rc3-mm1 (compile stats) John Cherry
2004-06-10  2:10 ` 2.6.7-rc3-mm1 Phil Brunner
2004-06-10  2:22   ` 2.6.7-rc3-mm1 Andrew Morton
2004-06-10  2:52   ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-10  8:59     ` 2.6.7-rc3-mm1 Phil Brunner
2004-06-10  5:16 ` 2.6.7-rc3-mm1 Clemens Schwaighofer
2004-06-10  5:31   ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-10  6:54     ` 2.6.7-rc3-mm1 Clemens Schwaighofer
2004-06-11  4:36 ` Paul Jackson [this message]
2004-06-11  5:47   ` 2.6.7-rc3-mm1 Andrew Morton
2004-06-11  5:53     ` 2.6.7-rc3-mm1 Paul Jackson
2004-06-09 15:33 2.6.7-rc3-mm1 Peter Maas
2004-06-09 15:52 ` 2.6.7-rc3-mm1 William Lee Irwin III
2004-06-09 20:03 2.6.7-rc3-mm1 Nguyen, Tom L
2004-06-10  0:51 2.6.7-rc3-mm1 Nguyen, Tom L
     [not found] <2576k-4hW-13@gated-at.bofh.it>
     [not found] ` <25LZK-88C-17@gated-at.bofh.it>
2004-06-11 10:48   ` 2.6.7-rc3-mm1 Andi Kleen
2004-06-11 11:32     ` 2.6.7-rc3-mm1 Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040610213659.0fd93039.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®