From: Greg KH <greg@kroah.com>
To: Luca Risolia <luca.risolia@studio.unibo.it>
Cc: linux-usb-devel@lists.sourceforge.net,
viro@parcelfarce.linux.theplanet.co.uk,
rtjohnso@eecs.berkeley.edu, linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] Re: Finding user/kernel pointer bugs [no html]
Date: Fri, 11 Jun 2004 09:17:48 -0700 [thread overview]
Message-ID: <20040611161747.GA2167@kroah.com> (raw)
In-Reply-To: <20040611063107.0c62e2f8.luca.risolia@studio.unibo.it>
On Fri, Jun 11, 2004 at 06:31:07AM +0200, Luca Risolia wrote:
> > unsigned int cmd, void* arg)
> > {
> > struct w9968cf_device* cam;
> > + void __user *user_arg = (void __user *)arg;
>
> The right place to apply this patch is in video_usercopy().
Um, the driver you just refered to does not use the video_usercopy()
function so your email doesn't make much sense in this context.
> Please have a look at definition of the function in videodev.c.
Please excuse me while I go get sick...
Anyway, that function needs to be properly marked up with __user if you
want it to live.
good luck,
greg k-h
next prev parent reply other threads:[~2004-06-11 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1BYXuJ-0006vd-RU@sc8-sf-list1.sourceforge.net>
2004-06-11 4:31 ` Luca Risolia
2004-06-11 4:52 ` viro
2004-06-11 16:17 ` Greg KH [this message]
2004-06-11 16:46 ` Luca Risolia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040611161747.GA2167@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=luca.risolia@studio.unibo.it \
--cc=rtjohnso@eecs.berkeley.edu \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®