From: Pavel Machek <pavel@ucw.cz>
To: Jeff Sipek <jeffpc@optonline.net>
Cc: Nigel Cunningham <ncunningham@linuxmail.org>,
Andrew Morton <akpm@osdl.org>,
herbert@gondor.apana.org.au, mochel@digitalimplant.org,
linux-kernel@vger.kernel.org
Subject: Re: Fix memory leak in swsusp
Date: Sun, 13 Jun 2004 17:57:24 +0200 [thread overview]
Message-ID: <20040613155724.GA2683@elf.ucw.cz> (raw)
In-Reply-To: <200406121932.49477.jeffpc@optonline.net>
Hi!
> > At some stage, you copy the page that contains the preempt count for the
> > process that is doing the suspending. If you use memcpy on a 3Dnow machine,
> > the preempt count is incremented prior to doing the copy of the page. Then,
> > at resume time, it is one too high.
>
> Well, if we know that it is one too high, why not decrement right after the
> resume?
You are suggesting very dirty hack. See archives why it is basically
undoable.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-06-13 15:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 13:04 Pavel Machek
2004-06-10 10:50 ` Herbert Xu
2004-06-10 10:56 ` Herbert Xu
2004-06-10 20:08 ` Pavel Machek
2004-06-10 21:24 ` Pavel Machek
2004-06-10 23:37 ` Herbert Xu
2004-06-11 9:48 ` Pavel Machek
2004-06-11 10:16 ` Herbert Xu
2004-06-11 10:23 ` Pavel Machek
2004-06-11 11:03 ` Herbert Xu
2004-06-12 3:17 ` Nigel Cunningham
2004-06-12 4:00 ` Andrew Morton
2004-06-12 11:10 ` Dave Jones
2004-06-13 15:59 ` Pavel Machek
2004-06-12 22:07 ` Nigel Cunningham
2004-06-12 23:32 ` Jeff Sipek
2004-06-13 15:57 ` Pavel Machek [this message]
2004-06-13 8:15 ` Herbert Xu
2004-06-12 6:45 ` Herbert Xu
2004-06-12 10:45 pavel
2004-06-12 22:09 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040613155724.GA2683@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=jeffpc@optonline.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=ncunningham@linuxmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®