From: Andi Kleen <ak@suse.de>
To: johnstul@us.ibm.com
Cc: linux-kernel@vger.kernel.org, linux@brodo.de
Subject: lost timer check in 2.6.7
Date: Wed, 16 Jun 2004 13:19:12 +0200 [thread overview]
Message-ID: <20040616131912.14b73b39.ak@suse.de> (raw)
2.6.7 has
+ /* ... but give the TSC a fair chance */
+ if (lost_count > 25)
+ cpufreq_delayed_get();
While looking at porting this code to x86-64 I noticed that this only runs for
the first lost timer event. In case of dynamic frequency which varies shouldn't this
be more like
if ((lost_count % 25) == 0)
cpufreq_delayed_get();
? Otherwise this heuristic will only work once.
-Andi
next reply other threads:[~2004-06-16 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-16 11:19 Andi Kleen [this message]
2004-06-16 15:15 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040616131912.14b73b39.ak@suse.de \
--to=ak@suse.de \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®