Re: [PATCH 2/4]Diskdump Update

[Christoph Hellwig <hch@infradead.org>]

On Thu, Jun 17, 2004 at 10:21:27PM +0900, Takao Indoh wrote:
> On Thu, 17 Jun 2004 13:49:57 +0100, Christoph Hellwig wrote:
> 
> >my old comments for this are still valid, please add the actual dumping
> >methods directly to scsi_host_template instead of a pointer to another
> >method vector, 
> 
> I have already done in the latest patch.

Okay.  Looks like I looked at an older patch, sorry.

> 
> diff -Nur linux-2.6.6.org/drivers/scsi/aic7xxx/aic7xxx_osm.c linux-2.6.6/drivers/scsi/aic7xxx/aic7xxx_osm.c
> --- linux-2.6.6.org/drivers/scsi/aic7xxx/aic7xxx_osm.c	2004-06-04 21:22:20.000000000 +0900
> +++ linux-2.6.6/drivers/scsi/aic7xxx/aic7xxx_osm.c	2004-06-16 19:34:16.000000000 +0900
> @@ -774,6 +774,10 @@
>  static int	   ahc_linux_bus_reset(Scsi_Cmnd *);
>  static int	   ahc_linux_dev_reset(Scsi_Cmnd *);
>  static int	   ahc_linux_abort(Scsi_Cmnd *);
> +#if defined(CONFIG_SCSI_DUMP) || defined(CONFIG_SCSI_DUMP_MODULE)
> +static int	   ahc_linux_sanity_check(struct scsi_device *);
> +static void	   ahc_linux_poll(struct scsi_device *);
> +#endif

I'd say implement these unconditionally, it's not _that_ much code..

> >please make it not a module of it's own but part of the
> >scsi code, 
> 
> Do you mean scsi_dump module should be merged with sd_mod.o or scsi_mod.o?

scsi_mod.o.

> I'll try sysfs attribute instead of this.

Okay, thanks.  Or some other way to find by host/channel/target/lun using
scsi_device_lookup.