From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Andreas Schwab <schwab@suse.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux/m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: make checkstack on m68k
Date: Thu, 17 Jun 2004 19:41:54 +0200 [thread overview]
Message-ID: <20040617174154.GA29029@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <je3c4uqum0.fsf@sykes.suse.de>
On Thu, 17 June 2004 13:41:59 +0200, Andreas Schwab wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>
> > I tried to add m68k support to `make checkstack', but got stuck due to my
> > limited knowledge of complex perl expressions. I actually need to catch both
> > expressions (incl. the one I commented out). Anyone who can help?
>
> Untested:
>
> $re = qr/.*(?:linkw %fp,|addw )#-([0-9]{1,4})(?:,%sp)?$/o;
Thanks! Geert, can you test the patch below?
[ It will break all platforms except m68k, but I don't want to touch
those REs before someone confirms it to work. ]
Jörn
--
Simplicity is prerequisite for reliability.
-- Edsger W. Dijkstra
checkstack.pl | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletion(-)
--- linux-2.6.7cow/scripts/checkstack.pl~cs_m68k 2004-06-17 14:58:25.000000000 +0200
+++ linux-2.6.7cow/scripts/checkstack.pl 2004-06-17 19:39:15.000000000 +0200
@@ -40,6 +40,11 @@
} elsif ($arch =~ /^ia64$/) {
#e0000000044011fc: 01 0f fc 8c adds r12=-384,r12
$re = qr/.*adds.*r12=-(([0-9]{2}|[3-9])[0-9]{2}),r12/o;
+ } elsif ($arch =~ /^m68k$/) {
+ #2b6c: 4e56 fb70 linkw %fp,#-1168
+ #1df770: defc ffe4 addaw #-28,%sp
+ #$re = qr/.*linkw %fp,#-([0-9]{1,4})/o;
+ $re = qr/.*(?:linkw %fp,|addw )#-[0-9]{1,4}(?:,%sp)?$/o;
} elsif ($arch =~ /^mips64$/) {
#8800402c: 67bdfff0 daddiu sp,sp,-16
$re = qr/.*daddiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o;
@@ -76,7 +81,7 @@
$func = $1;
}
if ($line =~ m/$re/) {
- my $size = $1;
+ my $size = $2;
$size = hex($size) if ($size =~ /^0x/);
if ($size > 0x80000000) {
prev parent reply other threads:[~2004-06-17 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-16 16:51 Geert Uytterhoeven
2004-06-16 18:04 ` Jörn Engel
2004-06-17 8:25 ` Geert Uytterhoeven
2004-06-17 11:45 ` Jörn Engel
2004-06-17 11:41 ` Andreas Schwab
2004-06-17 15:17 ` Finn Thain
2004-06-17 15:31 ` Andreas Schwab
2004-06-17 18:26 ` Jörn Engel
2004-06-17 19:15 ` Geert Uytterhoeven
2004-06-17 19:36 ` Geert Uytterhoeven
2004-06-18 13:02 ` Jörn Engel
2004-06-18 13:16 ` Geert Uytterhoeven
2004-06-17 17:41 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040617174154.GA29029@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®