From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: linux-kernel@vger.kernel.org, viro@math.psu.edu
Subject: Re: Patch: 2.6.7/fs/dnotify.c - make dn_lock a regular spinlock
Date: Fri, 18 Jun 2004 01:27:03 +1000 [thread overview]
Message-ID: <20040618012703.77b441c9.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20040617163826.A4558@freya>
[-- Attachment #1: Type: text/plain, Size: 910 bytes --]
Hi Adam,
On Thu, 17 Jun 2004 16:38:26 -0700 "Adam J. Richter" <adam@yggdrasil.com> wrote:
>
> In linux-2.6.7/fs/dnotify.c, the local varible dn_lock is
> declared as rw_lock_t, but the lock is only taken exclusively.
> So, let's "document" this fact, save a few bytes and save a few
> cycles by changing it to spinlock_t.
Fine by me, but other opinions are always welcome.
> If this patch looks acceptable to you, could you please
> tell the appropriate person to integrate it or advise me what to
> do if you want me to proceed some other way? I don't know if you
> submit your patches directly to Linus or through someone else,
> like Al Viro.
Well, Al was the last to modify the dnotify code, if memory serves.
Getting his OK is always a good idea for this sort of thing. Otherwise,
fine my me.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2004-06-17 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-17 23:38 Adam J. Richter
2004-06-17 10:53 ` Andrew Morton
2004-06-17 13:45 ` Adam J. Richter
2004-06-17 15:27 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040618012703.77b441c9.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®