From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Greg KH <greg@kroah.com>
Subject: Re: [PATCH 0/3] Couple of sysfs patches
Date: Fri, 18 Jun 2004 12:59:30 -0700 (PDT) [thread overview]
Message-ID: <20040618195930.42655.qmail@web81307.mail.yahoo.com> (raw)
Russell King wrote:
> void platform_device_unregister(struct platform_device * pdev)
> {
> - if (pdev)
> + int i;
> +
> + if (pdev) {
> device_unregister(&pdev->dev);
> +
> + for (i = 0; i < pdev->num_resources; i++) {
> + struct resource *r = &pdev->resource[i];
> + if (r->flags & (IORESOURCE_MEM|IORESOURCE_IO))
> + release_resource(r);
> + }
> + }
> }
Ok, now it's possibly just a nitpicking but would not it be "more correct"
if allocated resources were freed in reverse order?
--
Dmitry
next reply other threads:[~2004-06-18 20:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-18 19:59 Dmitry Torokhov [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-10 14:46 Dmitry Torokhov
2004-06-10 16:06 ` Russell King
2004-06-10 16:14 ` Greg KH
2004-06-10 18:17 ` Russell King
2004-06-10 20:25 ` Russell King
2004-06-16 22:51 ` Dmitry Torokhov
2004-06-18 19:29 ` Russell King
2004-06-18 20:39 ` Greg KH
2004-06-09 7:21 Dmitry Torokhov
2004-06-09 22:13 ` Greg KH
[not found] ` <200406091732.28684.dtor_core@ameritech.net>
2004-06-09 22:45 ` Greg KH
[not found] ` <200406091754.23303.dtor_core@ameritech.net>
2004-06-09 23:19 ` Greg KH
2004-06-10 6:40 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040618195930.42655.qmail@web81307.mail.yahoo.com \
--to=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®