From: Andrew Morton <akpm@osdl.org>
To: Keith Owens <kaos@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.7] bug_smp_call_function
Date: Sat, 19 Jun 2004 02:44:16 -0700 [thread overview]
Message-ID: <20040619024416.065f4026.akpm@osdl.org> (raw)
In-Reply-To: <5328.1087637808@kao2.melbourne.sgi.com>
Keith Owens <kaos@sgi.com> wrote:
>
> sg.c has been fixed to no longer call vfree() with interrupts disabled.
> Change smp_call_function() from WARN_ON to BUG_ON when interrupts are
> disabled. It was only set to WARN_ON because of sg.c.
I prefer the WARN_ON. It is exceedingly unlikely that the bug will cause
lockups or memory/data corruption or anything else, so why nuke the user's
box when we can trivially continue?
We'll be sent the bug report either way.
next prev parent reply other threads:[~2004-06-19 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-19 9:36 Keith Owens
2004-06-19 9:44 ` Andrew Morton [this message]
2004-06-19 9:54 ` Keith Owens
2004-06-19 9:59 ` William Lee Irwin III
2004-06-19 10:05 ` Keith Owens
2004-06-19 10:08 ` Andrew Morton
2004-06-19 10:14 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040619024416.065f4026.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®