Re: [PATCH] new device support for forcedeth.c second try

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Saturday 19 of June 2004 15:55, Francois Romieu wrote:
> Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net> :
> [...]
>
> > +static int phy_reset(struct net_device *dev)
> > +{
> > +	struct fe_priv *np = get_nvpriv(dev);
> > +	u32 miicontrol;
> > +	u32 microseconds = 0;
> > +	u32 milliseconds = 0;
> > +
> > +	miicontrol = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
> > +	miicontrol |= BMCR_RESET;
> > +	if (mii_rw(dev, np->phyaddr, MII_BMCR, miicontrol)) {
> > +		return -1;
> > +	}
> > +
> > +	//wait for 500ms
> > +	mdelay(500);
> > +
> > +	//must wait till reset is deasserted
> > +	while (miicontrol & BMCR_RESET) {
> > +		udelay(NV_MIIBUSY_DELAY);
> > +		miicontrol = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
> > +		microseconds++;
> > +		if (microseconds == 20) {
> > +			microseconds = 0;
> > +			milliseconds++;
> > +		}
> > +		if (milliseconds > 50)
> > +			return -1;
> > +	}
> > +	return 0;
> > +}
>
> Afaiks this function is not called from a spinlocked nor is it
> time-critical. You should make it use schedule_timeout().

msleep()