From: Andrew Morton <akpm@osdl.org>
To: Dan Aloni <da-x@colinux.org>
Cc: da-x@gmx.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] missing NULL check in drivers/char/n_tty.c
Date: Sun, 20 Jun 2004 23:58:24 -0700 [thread overview]
Message-ID: <20040620235824.5407bc4c.akpm@osdl.org> (raw)
In-Reply-To: <20040621063845.GA6379@callisto.yi.org>
Dan Aloni <da-x@gmx.net> wrote:
>
> The rest of the kernel treats tty->driver->chars_in_buffer as a possible
> NULL. This patch changes normal_poll() to be consistent with the rest of
> the code.
It would be better to change the rest of the kernel - remove the tests.
If any driver fails to implement ->chars_in_buffer() then we get a nice
oops which tells us that driver needs a stub handler.
next prev parent reply other threads:[~2004-06-21 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 6:38 Dan Aloni
2004-06-21 6:58 ` Andrew Morton [this message]
2004-06-21 7:36 ` Dan Aloni
2004-06-21 7:39 ` Andrew Morton
2004-06-21 8:24 ` Dan Aloni
2004-06-21 15:06 ` Paul Fulghum
2004-06-21 18:46 ` Andrew Morton
2004-06-21 19:52 ` Paul Fulghum
2004-06-21 22:48 ` Dan Aloni
2004-06-21 23:56 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040620235824.5407bc4c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=da-x@colinux.org \
--cc=da-x@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®