mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Langley <nwo@hacked.org>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problem with psmouse detecting generic ImExPS/2
Date: Mon, 21 Jun 2004 12:45:06 -0500	[thread overview]
Message-ID: <20040621124506.18b1f67a.nwo@hacked.org> (raw)
In-Reply-To: <20040621082831.GC1200@ucw.cz>

On Mon, 21 Jun 2004 10:28:31 +0200
Vojtech Pavlik <vojtech@suse.cz> wrote:

> On Mon, Jun 21, 2004 at 02:16:51AM -0500, Michael Langley wrote:
> > I noticed this after upgrading 2.6.6->2.6.7
> > 
> > Even after building psmouse as a module, and specifying the protocol,
> > all I get is an ImPS/2 Generic Wheel Mouse.
> > 
> > [root@purgatory root]# modprobe psmouse proto=exps
> > Jun 21 01:51:57 purgatory kernel: input: ImPS/2 Generic Wheel Mouse on
> > isa0060/serio1
> > 
> > My ImExPS/2 was detected correctly in <=2.6.6 and after examining the
> > current psmouse code, and the changes in patch-2.6.7, I can't figure out
> > what's breaking it.  A little help?
>  
> Maybe your mouse needs the ImPS/2 init before the ExPS/2 one. You can
> try to copy and-paste the ImPS/2 init once more in the code, without a
> return, of course.
> 
> -- 
> Vojtech Pavlik
> SuSE Labs, SuSE CR


Right.  That did the trick.

--- a/drivers/input/mouse/psmouse-base.c   2004-06-21 12:21:21.000000000 -0500
+++ b/drivers/input/mouse/psmouse-base.c   2004-06-21 12:12:39.000000000 -0500
@@ -455,6 +455,15 @@
                return PSMOUSE_GENPS;
        }

+   if (max_proto >= PSMOUSE_IMPS && intellimouse_detect(psmouse)) {
+
+      if (set_properties) {
+         set_bit(REL_WHEEL, psmouse->dev.relbit);
+         if (!psmouse->name)
+            psmouse->name = "Wheel Mouse";
+      }
+   }
+
        if (max_proto > PSMOUSE_IMEX) {
                int type = ps2pp_init(psmouse, set_properties);
                if (type > PSMOUSE_PS2)


[root@purgatory root]# modprobe psmouse proto=exps
Jun 21 12:41:36 purgatory kernel: input: ImExPS/2 Generic Wheel Mouse on isa0060/serio1

Much thanks for the help.  I couldn't live without the extra buttons in X.

  reply	other threads:[~2004-06-21 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-21  7:16 Michael Langley
2004-06-21  8:28 ` Vojtech Pavlik
2004-06-21 17:45   ` Michael Langley [this message]
2004-06-21 18:34     ` Vojtech Pavlik
2004-06-21 19:32       ` Michael Langley
2004-06-21 21:09         ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040621124506.18b1f67a.nwo@hacked.org \
    --to=nwo@hacked.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®