From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: tom.l.nguyen@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix MSI-X setup
Date: Tue, 22 Jun 2004 16:23:01 -0700 [thread overview]
Message-ID: <20040622232301.GB13197@kroah.com> (raw)
In-Reply-To: <52smcop5v7.fsf_-_@topspin.com>
On Mon, Jun 21, 2004 at 09:35:24PM -0700, Roland Dreier wrote:
> msix_capability_init() puts the offset of the MSI-X capability into
> pos, then uses pos as a loop index to clear the MSI-X vector table,
> and then tries to use pos as the offset again, which results in
> writing the MSI-X enable bit off into space.
>
> This patch fixes that by adding a new loop index variable and using
> that to clear the vector table.
>
> - Roland
>
> Signed-off-by: Roland Dreier <roland@tospin.com>
Applied, thanks.
greg k-h
next prev parent reply other threads:[~2004-06-22 23:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 2:22 Question on using MSI in PCI driver Roland Dreier
2004-06-22 3:50 ` Jeff Garzik
2004-06-22 3:54 ` Roland Dreier
2004-06-22 4:01 ` Jeff Garzik
2004-06-22 4:04 ` Roland Dreier
2004-06-22 4:03 ` [PATCH] Export msi_remove_pci_irq_vectors Roland Dreier
2004-06-22 4:35 ` [PATCH] Fix MSI-X setup Roland Dreier
2004-06-22 23:23 ` Greg KH [this message]
2004-06-22 23:57 ` Roland Dreier
2004-06-23 0:04 ` Greg KH
2004-06-22 8:45 ` [PATCH] Export msi_remove_pci_irq_vectors Christoph Hellwig
2004-06-22 16:21 [PATCH] Fix MSI-X setup Nguyen, Tom L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040622232301.GB13197@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®