mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fragmented SCSI disk messages in 2.6.7
Date: Wed, 23 Jun 2004 18:00:45 -0400	[thread overview]
Message-ID: <200406231803_MC3-1-854F-EC5D@compuserve.com> (raw)

Without this patch I get the following on bootup with media
inserted in a USB powered Zip 250:


sda: Spinning up disk....<6>EXT3 FS on hde3, internal journal
Adding 524152k swap on /dev/hdg2.  Priority:-1 extents:1
Adding 524152k swap on /dev/hde2.  Priority:-2 extents:1
.<6>kjournald starting.  Commit interval 5 seconds
((  --- Snip 17 lines of EXT3 mount messages --- ))
..<3>microcode: error! Bad data in microcode data file
microcode: Error in the microcode data
.....ready


Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>

--- 267.0/drivers/scsi/sd.c     2004-06-21 16:09:58.099832360 -0400
+++ 267.1/drivers/scsi/sd.c     2004-06-21 16:25:12.464827752 -0400
@@ -889,7 +889,7 @@ sd_spinup_disk(struct scsi_disk *sdkp, c
                } else if (SRpnt->sr_sense_buffer[2] == NOT_READY) {
                        unsigned long time1;
                        if (!spintime) {
-                               printk(KERN_NOTICE "%s: Spinning up disk...",
+                               printk(KERN_NOTICE "%s: Spinning up disk...\n",
                                       diskname);
                                cmd[0] = START_STOP;
                                cmd[1] = 1;     /* Return immediately */
@@ -912,7 +912,6 @@ sd_spinup_disk(struct scsi_disk *sdkp, c
                                current->state = TASK_UNINTERRUPTIBLE;
                                time1 = schedule_timeout(time1);
                        } while(time1);
-                       printk(".");
                } else {
                        /* we don't understand the sense code, so it's
                         * probably pointless to loop */
@@ -928,9 +927,9 @@ sd_spinup_disk(struct scsi_disk *sdkp, c
 
        if (spintime) {
                if (scsi_status_is_good(the_result))
-                       printk("ready\n");
+                       printk(KERN_NOTICE "%s: Disk ready\n", diskname);
                else
-                       printk("not responding...\n");
+                       printk(KERN_NOTICE "%s: Disk not responding...\n", diskname);
        }
 }
 


                 reply	other threads:[~2004-06-23 22:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200406231803_MC3-1-854F-EC5D@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®