From: viro@parcelfarce.linux.theplanet.co.uk
To: mikem@beardog.cca.cpqcorp.net
Cc: linux-kernel@vger.kernel.org, viro@www.linux.org.uk,
bob.montgomery@hp.com
Subject: Re: problems with alloc_disk in genhd.c
Date: Wed, 23 Jun 2004 22:24:59 +0100 [thread overview]
Message-ID: <20040623212459.GK12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040623211829.GC16336@beardog.cca.cpqcorp.net>
On Wed, Jun 23, 2004 at 04:18:29PM -0500, mikem@beardog.cca.cpqcorp.net wrote:
> In the ioctl we are doing
>
> /* count partitions 1 to 15 with sizes > 0 */
> for(i=0; i <MAX_PART; i++) {
... followed by what?
Array of per-partition structures contains the data for partitions,
obviously. And drivers have no damn business to ever touching it
directly, while we are at it.
BTW, take a look at the comment and loop following it. And note
that you are doing 16 iterations in the loop, contrary to what
the comment above it says.
next prev parent reply other threads:[~2004-06-23 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-23 21:18 mikem
2004-06-23 21:24 ` viro [this message]
2004-06-23 21:55 ` mikem
2004-06-23 22:03 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040623212459.GK12308@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=bob.montgomery@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@beardog.cca.cpqcorp.net \
--cc=viro@www.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®