From: viro@parcelfarce.linux.theplanet.co.uk
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Alexander Nyberg <alexn@telia.com>,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] A generic_file_sendpage()
Date: Fri, 25 Jun 2004 20:46:11 +0100 [thread overview]
Message-ID: <20040625194611.GQ12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040625191924.GA8656@wohnheim.fh-wedel.de>
On Fri, Jun 25, 2004 at 09:19:24PM +0200, Jörn Engel wrote:
> > + old_fs = get_fs();
> > + set_fs(KERNEL_DS);
Eeek... Don't do that, please - set_fs() is not a good thing to add for
no good reason.
> Your patch is *much* smaller than mine. Looks lean and mean. But you
> depend on the struct file* passed to generic_file_sendpage().
>
> One of my goals for 2.7 is to get rid of all users of struct file* in
> the various read-, write- and send-functions. Currently, there are
> four of them, you would introduce number five.
And how, pray tell, are you going to do that on filesystems that keep
part of context in file->private_data?
next prev parent reply other threads:[~2004-06-25 19:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 15:44 downgrade_write replacement in remap_file_pages Andrea Arcangeli
2004-06-08 16:31 ` Andrew Morton
2004-06-08 16:39 ` Linus Torvalds
2004-06-08 17:05 ` David Howells
2004-06-08 22:33 ` Andrea Arcangeli
2004-06-08 19:04 ` David Howells
2004-06-08 19:36 ` William Lee Irwin III
2004-06-08 22:52 ` Andrea Arcangeli
2004-06-09 12:19 ` [PATCH] A generic_file_sendpage() Alexander Nyberg
2004-06-10 19:49 ` Pavel Machek
2004-06-25 19:19 ` Jörn Engel
2004-06-25 19:46 ` viro [this message]
2004-06-25 20:03 ` Jörn Engel
2004-06-26 0:53 ` Trond Myklebust
2004-06-28 11:41 ` Jörn Engel
2004-06-25 20:05 ` Andreas Dilger
2004-06-25 20:09 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040625194611.GQ12308@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=alexn@telia.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®