From: Christoph Hellwig <hch@infradead.org>
To: Roland Dreier <roland@topspin.com>
Cc: long <tlnguyen@snoqualmie.dp.intel.com>,
linux-kernel@vger.kernel.org, ak@muc.de, akpm@osdl.org,
greg@kroah.com, jgazik@pobox.com, tom.l.nguyen@intel.com,
zwane@linuxpower.ca
Subject: Re: [PATCH]2.6.7 MSI-X Update
Date: Sat, 26 Jun 2004 09:27:14 +0100 [thread overview]
Message-ID: <20040626082713.GA11693@infradead.org> (raw)
In-Reply-To: <52n02r14ki.fsf@topspin.com>
On Fri, Jun 25, 2004 at 06:38:37PM -0700, Roland Dreier wrote:
> I like this new MSI patch much better since it has pci_disable_msi()
> and pci_disable_msix() (as well as using pci_read_config_xxx instead
> of bus ops), but I still feel the API is not quite right. I don't
> think the pci_disable_msi() and pci_disable_msix() functions should
> only be for error paths; I think that they should always be used to
> undo the effect of pci_enable_msi() or pci_enable_msix() when a driver
> is unloading, and that request()/free_irq() should not have any effect
> on a device's MSI state.
Agreed. Non-symmetric APIs are very bad.
> As a concrete example, the e1000 net driver does request_irq() in its
> e1000_up() function and free_irq() in its e1000_down() function.
> Basically, the driver will do request_irq() when the user does
> "ifconfig up" and free_irq() when the user does "ifconfig down".
Lots of networking drivers do that..
next prev parent reply other threads:[~2004-06-26 8:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 1:21 long
2004-06-26 0:30 ` [PATCH]2.6.7 " Roland Dreier
2004-06-26 1:38 ` Roland Dreier
2004-06-26 8:27 ` Christoph Hellwig [this message]
2004-06-26 17:30 ` Roland Dreier
-- strict thread matches above, loose matches on Subject: below --
2004-07-19 15:36 Nguyen, Tom L
2004-07-15 15:46 Nguyen, Tom L
2004-07-13 22:02 long
2004-07-15 2:14 ` [PATCH]2.6.7 " Roland Dreier
2004-07-18 1:25 ` Roland Dreier
2004-06-24 16:29 Nguyen, Tom L
2004-06-23 22:03 Nguyen, Tom L
2004-06-24 1:42 ` Roland Dreier
2004-06-24 6:37 ` Zwane Mwaikambo
2004-06-24 7:27 ` Roland Dreier
2004-06-23 16:58 Nguyen, Tom L
2004-06-23 16:49 Nguyen, Tom L
2004-06-22 23:06 Nguyen, Tom L
2004-06-22 21:48 long
2004-06-22 23:57 ` Roland Dreier
2004-06-23 0:26 ` Jeff Garzik
2004-06-23 1:18 ` Roland Dreier
2004-06-23 3:45 ` Roland Dreier
2004-06-23 16:50 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040626082713.GA11693@infradead.org \
--to=hch@infradead.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=jgazik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=tlnguyen@snoqualmie.dp.intel.com \
--cc=tom.l.nguyen@intel.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome