From: Andrew Morton <akpm@osdl.org>
To: Robert Picco <Robert.Picco@hp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hpet related
Date: Mon, 28 Jun 2004 13:27:04 -0700 [thread overview]
Message-ID: <20040628132704.50874705.akpm@osdl.org> (raw)
In-Reply-To: <40E05EC2.20700@hp.com>
Robert Picco <Robert.Picco@hp.com> wrote:
>
> +static inline void hpet_timer_reserved(struct hpet_data *hd, int timer)
> +{
> + hd->hd_state |= (1 << timer);
> + return;
> +}
The identifier "hpet_timer_reserved" implies (to me) that the function
queries something. Except it doesn't.
Would "hpet_reserve_timer" be a better choice?
next prev parent reply other threads:[~2004-06-28 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-28 18:09 Robert Picco
2004-06-28 20:27 ` Andrew Morton [this message]
2004-06-28 21:23 ` Robert Picco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628132704.50874705.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Robert.Picco@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®