From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Joshua <jhudson@cyberspace.org>
Cc: miller@techsource.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] restore floppy boot image
Date: Wed, 30 Jun 2004 14:55:06 -0700 [thread overview]
Message-ID: <20040630145506.46d3af16.rddunlap@osdl.org> (raw)
In-Reply-To: <Pine.SUN.3.96.1040630174704.20503A-100000@grex.cyberspace.org>
On Wed, 30 Jun 2004 17:52:30 -0400 (EDT) Joshua wrote:
| Thanks for the time in reading the patch.
|
| Hmm. pop %ax after the jmp is a clear bug. Must have been a zero
| on the stack when I tested it. <g>
|
| For the clobbering of al just before kernel entry, that is badly arranged
| code although it doesn't matter (mov $0, %al turns out to be no-op).
No-op should be some form/variant of xchg %ax,%ax
(not mov to %al -- the latter needs to do something.)
| I'll fix the bugs if anybody still wants the patch.
| I'll fix it anyway for myself <g>.
--
~Randy
next prev parent reply other threads:[~2004-06-30 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-30 18:45 Joshua
2004-06-30 18:56 ` Brian Gerst
2004-06-30 20:34 ` Timothy Miller
2004-06-30 21:33 ` Timothy Miller
2004-06-30 21:52 ` Joshua
2004-06-30 21:55 ` Randy.Dunlap [this message]
2004-07-01 14:50 ` Timothy Miller
2004-06-30 23:17 ` Tobias Diedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040630145506.46d3af16.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=jhudson@cyberspace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miller@techsource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®