From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266501AbUGBIQx (ORCPT ); Fri, 2 Jul 2004 04:16:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266511AbUGBIQx (ORCPT ); Fri, 2 Jul 2004 04:16:53 -0400 Received: from fw.osdl.org ([65.172.181.6]:13260 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266501AbUGBIQ2 (ORCPT ); Fri, 2 Jul 2004 04:16:28 -0400 Date: Fri, 2 Jul 2004 01:15:25 -0700 From: Andrew Morton To: Yichen Xie Cc: linux-kernel@vger.kernel.org, Manfred Spraul Subject: Re: [BUGS] [CHECKER] 99 synchronization bugs and a lock summary database Message-Id: <20040702011525.1f0d0829.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Yichen Xie wrote: > > http://glide.stanford.edu/linux-lock/err1.html (69 errors) ipc/sem.c:find_undo() seems to be a false positive. That function calls sem_revalidate() which may or may not require a sem_unlock() afterwards, depending on what value it returned. I'm not sure it's worth teaching the tool about this - I'd refer to strangle the IPC code.