From: Greg KH <greg@kroah.com>
To: linas@austin.ibm.com
Cc: inuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [PATCH] 2.6 RPAPHP structure size/performance
Date: Fri, 2 Jul 2004 13:56:15 -0700 [thread overview]
Message-ID: <20040702205615.GB29580@kroah.com> (raw)
In-Reply-To: <20040702112154.O21634@forte.austin.ibm.com>
On Fri, Jul 02, 2004 at 11:21:54AM -0500, linas@austin.ibm.com wrote:
>
> Hi Greg,
>
> Please review and apply the following patch if you find it agreeable.
>
> This patch does not make any functional changes, but does improve
> both performance and memory usage by rearranging structure elements.
>
> The need for these changes became appearent during a code review of
> the disassembly involving this structure. The memory footprint of this
> structure is made smaller by grouping the byte fields next to each other.
> The access of the list_head can be simplified by making it the first element
> of the structure, thus avoiding a needless add-immediate without negatively
> impacting any of the other accesses.
>
> Signed-off-by: Linas Vepstas <linas@linas.org>
Applied, thanks.
greg k-h
prev parent reply other threads:[~2004-07-02 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-02 16:21 linas
2004-07-02 20:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040702205615.GB29580@kroah.com \
--to=greg@kroah.com \
--cc=inuxppc64-dev@lists.linuxppc.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®