From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261239AbUGHVXE (ORCPT ); Thu, 8 Jul 2004 17:23:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261347AbUGHVXE (ORCPT ); Thu, 8 Jul 2004 17:23:04 -0400 Received: from fw.osdl.org ([65.172.181.6]:6832 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261239AbUGHVXB (ORCPT ); Thu, 8 Jul 2004 17:23:01 -0400 Date: Thu, 8 Jul 2004 14:21:53 -0700 From: Andrew Morton To: "R. J. Wysocki" Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.7-mm6: system hang with KAMix on dual Opteron w/ NUMA Message-Id: <20040708142153.60c2cb69.akpm@osdl.org> In-Reply-To: <200407082324.55181.rjwysocki@sisk.pl> References: <200407082324.55181.rjwysocki@sisk.pl> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org "R. J. Wysocki" wrote: > > I've just discovered that I'm (consistently) able to hang the system solid by > trying to adjust the sound volume using KAMix on 2.6.7-mm6 (SuSE 9.1/ AMD64). Please ensure that your kernel has this patch: --- 25/sound/core/control.c~snd_ctl_read-locking-fix-fix 2004-07-06 21:27:51.618683360 -0700 +++ 25-akpm/sound/core/control.c 2004-07-06 21:27:51.622682752 -0700 @@ -1116,7 +1116,7 @@ static ssize_t snd_ctl_read(struct file wait_queue_t wait; if ((file->f_flags & O_NONBLOCK) != 0 || result > 0) { err = -EAGAIN; - goto out; + goto __end; } init_waitqueue_entry(&wait, current); add_wait_queue(&ctl->change_sleep, &wait); @@ -1137,7 +1137,7 @@ static ssize_t snd_ctl_read(struct file kfree(kev); if (copy_to_user(buffer, &ev, sizeof(snd_ctl_event_t))) { err = -EFAULT; - goto __end; + goto out; } spin_lock_irq(&ctl->read_lock); buffer += sizeof(snd_ctl_event_t); _