From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, mason@suse.com
Subject: Re: writepage fs corruption fixes
Date: Fri, 9 Jul 2004 06:42:05 +0200 [thread overview]
Message-ID: <20040709044205.GF20947@dualathlon.random> (raw)
In-Reply-To: <20040708212923.406135f0.akpm@osdl.org>
Hi Andrew,
On Thu, Jul 08, 2004 at 09:29:23PM -0700, Andrew Morton wrote:
> ooh, nasty, yes. You must be testing the crap out if it.
;) thanks for the immediate review!
BTW, the new mpage code looks great, it's a pity that reiserfs and ext3
don't use it yet.
> PG_writeback protects the page from truncate, from invalidate and from page
> reclaim. pagevec_strip() won't touch the buffers due to the
> PageWriteback() test in try_to_release_page(). So I think we're OK in
> there. I can add a couple more coment fixes for this.
Indeed, sorry. I should have watched more carefully for the writeback
bitflag but I was still in "anything that looks a bug close it and try
again" mode when I made the two "noop" changes ;)
next prev parent reply other threads:[~2004-07-09 4:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-09 4:01 Andrea Arcangeli
2004-07-09 4:06 ` Andrea Arcangeli
2004-07-09 4:19 ` Andrea Arcangeli
2004-07-09 4:29 ` Andrew Morton
2004-07-09 4:42 ` Andrea Arcangeli [this message]
2004-07-09 4:56 ` Andrew Morton
2004-07-09 12:43 ` Chris Mason
2004-07-10 0:16 ` Andrea Arcangeli
2004-07-10 1:07 ` Andrea Arcangeli
2004-07-10 4:30 ` Andrew Morton
2004-07-10 4:59 ` Andrea Arcangeli
2004-07-10 5:56 ` Andrew Morton
2004-07-10 6:11 ` Andrea Arcangeli
2004-07-10 6:13 ` Andrew Morton
2004-07-14 16:14 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040709044205.GF20947@dualathlon.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®