From: David Eger <eger@havoc.gtf.org>
To: Andrew Morton <akpm@osdl.org>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] radeonfb: cleanup and little fixes
Date: Mon, 12 Jul 2004 03:40:48 -0400 [thread overview]
Message-ID: <20040712074048.GA19875@havoc.gtf.org> (raw)
In-Reply-To: <20040711233002.1ec2100f.akpm@osdl.org>
On Sun, Jul 11, 2004 at 11:30:02PM -0700, Andrew Morton wrote:
> > if (rinfo->mon1_EDID)
> > kfree(rinfo->mon1_EDID);
> > if (rinfo->mon2_EDID)
> > kfree(rinfo->mon2_EDID);
>
> kfree(NULL) is legal, and this is a slow-path. Those tests can be taken
> out next time, unless such a thing offends you.
I guess I wasn't zealous enough in my cleanup ;-)
(changing it doesn't bother me, I just hadn't noticed it)
I really appreciate the work you put in looking through all of the
patches you get. Code review is a huge job, something I don't think
James really has time for, but somehow you find it :)
-dte
prev parent reply other threads:[~2004-07-12 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-12 6:22 David Eger
2004-07-12 6:30 ` Andrew Morton
2004-07-12 7:40 ` David Eger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040712074048.GA19875@havoc.gtf.org \
--to=eger@havoc.gtf.org \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®