mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Mikael Pettersson <mikpe@csd.uu.se>,
	axboe@suse.de, wli@holomorphy.com,
	B.Zolnierkiewicz@elka.pw.edu.pl, akpm@osdl.org,
	dgilbert@interlog.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix
Date: Thu, 15 Jul 2004 16:58:15 +0100	[thread overview]
Message-ID: <20040715155815.GH32326@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <40F68212.2020405@pobox.com>

On Thu, Jul 15, 2004 at 09:09:38AM -0400, Jeff Garzik wrote:
> >Compilers for top-down (define-before-use) languages like C
> >have traditionally also worked in a top-down fashion, processing
> >one top-level declaration at a time. Forward references are
> >either errors, or are (when a proper declaration is in scope)
> >left to the linker to resolve.
> >
> >Processing an entire compilation-unit (e.g. whole C file)
> >as a single unit is typically _only_ done when either the
> >language semantics requires it (not C, but e.g. Haskell),
> >or when very high optimisation levels are requested.
> 
> Or in the case where you parse the entire file, then generate code for 
> the entire file in a separate pass.  Which does NOT imply 
> unit-at-a-time, for the readers at home.  It just implies generation of 
> the AST.

... which GCC didn't use to do.  It used to generate RTL directly from
the source.  From the GCC news and announcements page:

October 5, 2001
    Alexandre Oliva of Red Hat has generalized the tree inlining
    infrastructure, formerly in the C++ front end, so that it is now
    used in the C front end too.

> >In the case of gcc-3.4.1 failing to inline, you are asking
> >gcc to do something (peeking forward) which it never has
> >promised to do. And with the kernel using -fno-unit-at-a-time
> >for stack conservation reasons, gcc is actually being _told_
> >not to do global compilation.
> >
> >This is not a gcc bug, nor is it being "exceedingly dumb".
> 
> Actually, yes it is.

No, it's not.  It's always been this way.  You seemed to ignore that
message I posted yesterday.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  reply	other threads:[~2004-07-15 15:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-15  9:46 Mikael Pettersson
2004-07-15 13:09 ` Jeff Garzik
2004-07-15 15:58   ` Matthew Wilcox [this message]
2004-07-15 14:36 ` William Lee Irwin III
  -- strict thread matches above, loose matches on Subject: below --
2004-07-14 17:51 Mikael Pettersson
2004-07-14 18:36 ` Jeff Garzik
2004-07-14 19:05   ` Adrian Bunk
2004-07-14 21:35   ` Andrew Morton
2004-07-14 23:39     ` Jeff Garzik
2004-07-14 22:39       ` Andrew Morton
2004-07-15  0:19       ` Matthew Wilcox
2004-07-15  5:56     ` Jens Axboe
2004-07-15  6:12       ` William Lee Irwin III
2004-07-15 15:42     ` Douglas Gilbert
2004-07-14 12:16 Mikael Pettersson
2004-07-14 15:52 ` Jeff Garzik
2004-07-14 16:42   ` Adrian Bunk
2004-07-14 16:44     ` Jeff Garzik
2004-07-14 16:54       ` Adrian Bunk
2004-07-14 17:31         ` Bartlomiej Zolnierkiewicz
2004-07-14 18:33           ` Adrian Bunk
2004-07-14 18:44             ` Jeff Garzik
2004-07-14 19:06             ` Douglas Gilbert
2004-07-26 22:09             ` Andrew Morton
2004-07-14 18:34           ` Jeff Garzik
2004-07-14 18:31         ` Jeff Garzik
2004-07-14 15:57 ` Bartlomiej Zolnierkiewicz
2004-07-14 15:59   ` Jeff Garzik
2004-07-26 21:53 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040715155815.GH32326@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=dgilbert@interlog.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mikpe@csd.uu.se \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®